Update stage environments #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
We were checking for definedness on USE_LOCALHOST_FORK instead of checking for the value `true` specifically, which meant the localhost provider was being initialized when it didn't need to be and spitting out spurious errors into the console.
This just reduces `eth_chainId` calls because we know the provider won't change chain ids on us.
There will be a period during which we want to tease the dApp but not let anyone in. For this period, the island mode `teaser` is added. This mode hides the Feedback link, disables Connect wallet, and replaces the center modal with one that says the portal opens soon. For testing, USE_TENDERLY_FORK is used to move the island mode to `default` on load. We may want to introduce a separate flag for this.
Resolves: #444 Assets (xp, leaderboard) will be visible under the link, eg: https://app.taho.xyz/assets/xp/9/leaderboard.json 
The idea is thet whenever some PR gets merged to `main` we want to auto-create another PR that updates `stage-live` branch with changes from `main`. If there's already a PR open between those two branches, we want it to be updated with the latest `main` changes. In next commits we'll add more jobs (syncing different deployment-related branches) to the workflow.
For now it's only for the testing purposes.
The value should be an array
Once some changes land on `stage-live` branch, we'll automatically create a PR that wants to merge those changes to the `release` branch. Upon merging such PR the production environment will be updated.
Once some changes land on `stage-live` branch, we'll automatically create a PR that wants to merge those changes to the `release` branch. Upon merging such PR the production environment will be updated.
We want to trigger the jobs only after changes to specific branches.
We want to trigger the jobs only after changes to specific branches.
✅ Deploy Preview for taho-development ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This is used in place of USE_TENDERLY_FORK to determine when to put the UI into a teaser state, where the portal says it's coming soon and wallet connection is disabled. Feedback is also hidden in this mode.
Added docs about our development and testing cycle.
[Motivating thread](https://discord.com/channels/1079490158639976609/1164622118420488242). The UI may need additional tweaks depending on feedback from Vlad, but let's get this up sooner rather than later so the domain has something up that isn't the full dApp. From the commit: > There will be a period during which we want to tease the dApp but not let anyone in. For this period, the island mode `teaser` is added. This mode hides the Feedback link, disables Connect wallet, and replaces the center modal with one that says the portal opens soon. > > For testing, USE_TENDERLY_FORK is used to move the island mode to `default` on load. We may want to introduce a separate flag for this. Two other tidbits are included here: - `StaticJsonRpcBatchProvider` is a quick thing I added mashing together `StaticJsonRpcProvider`, which only checks the chain id once (we were doing a lot of `eth_chainId` calls) and `JsonRpcBatchProvider`, whose batching we're familiar with already. - I also fixed the localhost provider's guard so that we never fire up the localhost provider in production/test builds. <img width="1633" alt="Screenshot 2023-10-19 at 15 24 33" src="https://github.com/tahowallet/dapp/assets/8245/8863359d-9aaf-4e1f-8e51-cc53cb41b6eb">
jagodarybacka
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request that upon merging will update stage environments with recent
mainchanges.