Remove bundler dependency #50
Conversation
| @@ -18,7 +18,7 @@ namespace :unicorn do | |||
| info "unicorn is running..." | |||
| else | |||
| with rails_env: fetch(:rails_env) do | |||
| execute :bundle, "exec unicorn", "-c", fetch(:unicorn_config_path), "-E", fetch(:unicorn_rack_env), "-D", fetch(:unicorn_options) | |||
| execute :unicorn, "-c", fetch(:unicorn_config_path), "-E", fetch(:unicorn_rack_env), "-D", fetch(:unicorn_options) | |||
|
+1 |
| - When running tasks not during a full deployment, you may need to run the `rvm:hook`: | ||
|
|
||
| `cap production rvm:hook unicorn:start` | ||
|
|
||
| - To use unicorn with bundler, you'll have to add the `capistrano-bundler` gem, and add the unicorn command to the bundle bins: | ||
|
|
||
| `set :bundle_bins, fetch(:bundle_bins, []).push('unicorn')` |
There was a problem hiding this comment.
also you need hook rvm (if you use one):
set :rvm_map_bins, fetch(:rvm_map_bins, []).push('unicorn')
or if rbenv:
set :rbenv_map_bins, fetch(:rbenv_map_bins).to_a.concat(%w(unicorn))
There was a problem hiding this comment.
Or rbenv for that matter, but people who will use those implementations, will probably know the implication of the usage.
There was a problem hiding this comment.
no I didn't knew... I needed to read how sidekiq capistrano tasks was implemented.
There was a problem hiding this comment.
set :rbenv_map_bins, fetch(:rbenv_map_bins).to_a.concat(%w(unicorn))
is incorrect, or at least cumbersome.
this is more concise:
set :rbenv_map_bins, fetch(:rbenv_map_bins, []).push('unicorn')There was a problem hiding this comment.
but it work's: set :rvm_map_bins, fetch(:rvm_map_bins).to_a.concat(%w(unicorn)) or set :rbenv_map_bins, fetch(:rbenv_map_bins).to_a.concat(%w(unicorn)) or for : chruby_map_bins or for bundle_bins
This change makes using bundler optional
More on this here: https://github.com/capistrano/bundler#usage