feat: add more scripts
#1997
feat: add more scripts
#1997
Conversation
`lint:fix` `check` `preview` `typecheck` `format:write` `format:check`
programming-with-ia
requested review from
juliusmarminge,
nexxeln,
t3dotgg and
c-ehrlich
as code owners
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@programming-with-ia is attempting to deploy a commit to the t3-oss Team on Vercel. A member of the Team first needs to authorize it. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
cli/template/base/package.json
Outdated
| "format:write": "prettier --write \"**/*.{ts,tsx,js,jsx,mdx}\" --cache", | ||
| "format:check": "prettier --check \"**/*.{ts,tsx,js,jsx,mdx}\" --cache" |
There was a problem hiding this comment.
Not all templates gets prettier installed, only if you have tailwind iirc so this wouldn't work ootb
There was a problem hiding this comment.
Thank you for the feedback! Just to clarify, would you like me to remove the scripts entirely, or would you prefer that I integrate them through tailwind.ts instead, similar to this example? I'm happy to make the adjustments based on your preference.
There was a problem hiding this comment.
modify cli\src\installers\tailwind.ts
There was a problem hiding this comment.
yea similar to how the db installers adds the db:push scripts etc this can for now be handled in the tailwind installeer if/until there're more formatting options
There was a problem hiding this comment.
Done ✅
There was a problem hiding this comment.
you need to run pnpm format in root. there are formatting issues in the PR
There was a problem hiding this comment.
@juliusmarminge Done
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes. Read the contributing guide (you checked the box when creating the PR
There was a problem hiding this comment.
Yes. Read the contributing guide (you checked the box when creating the PR
☺️ )
🙏 🫡😔
Closes #1981
✅ Checklist
Changelog
More
Scriptsadded incli/template/base/package.jsonlint:fixcheckpreviewtypecheckformat:writeformat:checkScreenshots
cli/template/base/package.json💯