Array fix where '/Off' is first element in array #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear creators of fillpdf,
In your code, in the "write_fillable_pdf" function, it assumes that "/Off" is always the second element in the array and "/label_name" is the first, then you remove the "/" in the first element of the array to get "label_name" and compare whether there is an intersection with the target value for the key of this question, but there are cases where "/Off" is the first value in the array with "/label_name" and then after processing operations we will have such an array ["Off", "/label_name"] (in our case - ["Off", "/Uncertain"]) and we will look for an intersection with ["label_name"] (in our case ["Uncertain"]). It is obvious that it will not be found and one of the fields will not be filled, which is what happened in our form. So, this PR is a solution to this little problem in your wonderful library. Ready for your questions.
Best regards
Petro.