Fix Json db losing already saved pasta's on crash/power failure #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The database file was truncated before writes the complete list of pastas from memory back into it. If power failed in between or microbin crashed all pasta's would be lost. This creates a new file then replaces the old with it once the writing is done. Note the replace (rename) is usually (definitly on linux) atomic. Therefore it either succeeds or fails and only the new changes are lost.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+23
to
+25
| let tmp_file = File::create(&tmp_file_path).expect(&format!( | ||
| "failed to create temporary database file for writing. path: {tmp_file_path}" | ||
| )); |
Check warning
Code scanning / clippy
use of expect followed by a function call Warning
|
This fixes #278 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The database file was truncated before writes the complete list of pastas from memory back into it. If power failed in between or microbin crashed all pasta's would be lost.
This creates a new file then replaces the old with it once the writing is done. Note the replace (rename) is usually (definitly on linux) atomic. Therefore it either succeeds or fails and only the new changes are lost.