use si.error.message instead of error in spans #5265
+19
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we do something like `error=?err` the `error` attribute in Honeycomb is mapped to a bool, so we lose the context. By sending the error struct to `si.error.message` we get more context. This would have been helpful when troubleshooting this week, so I tried to update them everywhere for consistency sake.
Dependency Review✅ No vulnerabilities or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
github-actions
bot
added
A-veritech
britmyerss
force-pushed
the
brit/use-si-error-message
branch
from
8fe90d6 to
01d3428
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we do something like
error=?errtheerrorattribute in Honeycomb is mapped to a bool, so we lose the context. By sending the error struct tosi.error.messagewe get more context. This would have been helpful when troubleshooting this week, so I tried to update them everywhere for consistency sake.