Add option to save the BuildSourcesEphemeral overlay. #3336
Conversation
behrmann
force-pushed
the
cachephemeral
branch
from
d997c3d to
1609226
Compare
|
It's a hack, but it's quite a useful hack and when one has more than single build script, having the setup code in each is a lot of boilerplate and if one wants to reduce it, it means adding a bit of shell wrapper into the tools tree and/or image and still a bit of boilerplate. I've instead added another line to the docs and some explosion emojis around it. I've added the don't merge label for now, though, since I need to test this once more. The thing I build segfaulted and I need to see whether it's somehow from this are the thing just being broken. |
|
I'm also happy to call the option |
behrmann
force-pushed
the
cachephemeral
branch
from
1609226 to
28fe4c8
Compare
behrmann
force-pushed
the
cachephemeral
branch
from
92a0ba0 to
73e6844
Compare
behrmann
force-pushed
the
cachephemeral
branch
2 times, most recently
from
40fb5f2 to
f5b4fce
Compare
|
Good catch, I thought it was there, that's why it's mentioned in the man page. I must have lost this in a rebase. |
mkosi/mounts.py
Outdated
| with contextlib.ExitStack() as stack: | ||
| options: list[PathString] = [] | ||
|
|
||
| for t in config.build_sources: | ||
| src, dst = t.with_prefix("/work/src") | ||
|
|
||
| if ephemeral: | ||
| upperdir = Path(stack.enter_context(tempfile.TemporaryDirectory(prefix="volatile-overlay"))) | ||
| os.chmod(upperdir, src.stat().st_mode) | ||
| if ephemeral == BuildSourcesEphemeral.buildcache and config.build_dir is not None: |
There was a problem hiding this comment.
I would fail if this is specified but there's no build directory configured
behrmann
force-pushed
the
cachephemeral
branch
from
f5b4fce to
5eff7d4
Compare
This systematises a trick Daan showed me a while back and that I've been using most everywhere since. Having it in mkosi itself makes it easier to use for everybody.