Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:add deepin distribution #3253

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

heysion
Copy link

@heysion heysion commented Dec 2, 2024

Add deepin Root File System Creation with mkosi Support Starting from deepin v20 (Apricot).

Users can now utilize mkosi to build the root file systems for both deepin v20 (Apricot) and v23 (Beige). Here's how:

  • For deepin in v20 (Apricot):

    mkosi -d deepin
    
  • For deepin v23 (Beige) specifically, with the repository mirror:

    mkosi -d deepin -r beige -m https://community-packages.deepin.com/deepin/beige
    

Sidenote: In accordance with the deepin branding guidelines, the preferred usage is to start the name "deepin" with a lowercase 'd', akin to how "openSUSE" begins with a lowercase 'o'. Therefore, in this context, we have intentionally used "deepin" rather than "Deepin"—this is not a typographical error. :)

Description:

Log:
Comment on lines +199 to +208
if (
d
in {
Distribution.debian,
Distribution.deepin,
Distribution.ubuntu,
Distribution.kali,
}
and version_codename
):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (
d
in {
Distribution.debian,
Distribution.deepin,
Distribution.ubuntu,
Distribution.kali,
}
and version_codename
):
if d and d.is_apt_distribution() and version_codename:

Comment on lines +173 to +175
def detect_distribution(
root: Path = Path("/"),
) -> tuple[Optional[Distribution], Optional[str]]:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't change this if it is not needed.

Copy link
Author

@heysion heysion Dec 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't change this if it is not needed.

Okay , I will modify this .

But I got a problem now. The build image.raw cannot be started by qemu. I am still trying to fix this problem.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This copies the debian.py quite fully, which would be a maintenance burden long term. Can you have a look at kali.py for a pointer how to implement a Debian derivative?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your reminder . The current v20 and v23 are based on Debian, but the next version has many incompatibilities with Debian. Therefore, it was considered better to copy debian.py at the time.

After I fix the current qemu + oci issues, I will reevaluate how to use the kali.py methods to ensure compatibility with next versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants