-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix repart definition for ESP builds #3125
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yikes, good catch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to pass something like --ro-bind, uki, workdir(uki)
to the sandbox options of make_image()
Do we? The uki is implicitly mounted as part of the staging dir under I am really not sure where the best place to put this fix is. |
And I took a look at the logs when building a disk image with a UKI as a bootloader but was unable to find the error in that case... |
You are correct that it's available in the sandbox, it's the "implicit" that's the problem. We mount in the staging directory for another unrelated reason and that might change in the future so I'd like to make it explicit. Just adding an |
ff8355f
to
b736e42
Compare
Currently ESP builds succeed but do not actually include any UKI as sd-repart silently ignore that they are missing. I am not sure if this is the correct place to add that fix. Maybe a
--copy-from
in the repart invocation would be cleaner.Also, disk builds with UKI bootloaders are still broken - not sure if anything else is affected, too