Support mkosi ssh for multiple running instances of the same image #2564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaanDeMeyer
force-pushed
the
ssh
branch
3 times, most recently
from
85a6271
to
8f06ef3
Compare
behrmann
approved these changes
Mar 28, 2024
septatrix
reviewed
Mar 28, 2024
DaanDeMeyer
force-pushed
the
ssh
branch
4 times, most recently
from
9a518f6
to
4ebd6e3
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
behrmann
approved these changes
Mar 28, 2024
Let's add a stopgap solution until systemd-machined supports everything we need. We maintain a super basic JSON state file in the runtime directory that is used to map a machine name to the corresponding SSH proxy command. We also store the path to the ssh key in there so that mkosi ssh can be run from every directory. The new Machine= option allows selecting the machine name to use. Unless set explicitly, we also use the machine name as the hostname for the machine.
These might be long running so let's make them more introspectible by allocating a scope for them and registering them with machined if possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's add a stopgap solution until systemd-machined supports everything we need. We maintain a super basic JSON state file in the runtime directory that is used to map a machine name to the corresponding SSH proxy command.
We also store the path to the ssh key in there so that mkosi ssh can be run from every directory.
The new Machine= option allows selecting the machine name to use. Unless set explicitly, we also use the machine name as the hostname for the machine.