Add FnLock key #263
Merged
Add FnLock key #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crawfxrd
force-pushed
the
wip/fnlock-custom-key
branch
from
825f115
to
d37ac12
Compare
|
Hello, is there a reason why this is left as draft and not merged? I've tested this change on |
crawfxrd
force-pushed
the
wip/fnlock-custom-key
branch
from
d37ac12
to
6cd4335
Compare
jackpot51
previously approved these changes
Jan 18, 2023
leviport
previously approved these changes
Jan 30, 2023
There was a problem hiding this comment.
This works great on darp8.
I've opened pop-os/keyboard-configurator#159 so we can track getting it added to the configurator.
crawfxrd
force-pushed
the
wip/fnlock-custom-key
branch
2 times, most recently
from
9528c30
to
fa2a4d8
Compare
leviport
previously approved these changes
Jan 30, 2023
crawfxrd
force-pushed
the
wip/fnlock-custom-key
branch
from
fa2a4d8
to
cc745cf
Compare
Implement a FnLock toggle that behaves as follows: - Disabled: F1-F12 are normal - Enabled: F1-F12 are the alternate function Signed-off-by: Tim Crawford <[email protected]>
crawfxrd
force-pushed
the
wip/fnlock-custom-key
branch
from
cc745cf
to
9876d9a
Compare
|
Default key has been changed from |
leviport
previously approved these changes
Jul 24, 2023
|
I have concerns with the lack of an indicator. This is a great thing for users who want it, but for users who are unaware of this feature, accidentally toggling function lock could be very hard for them to undo. |
crawfxrd
force-pushed
the
wip/fnlock-custom-key
branch
from
9876d9a
to
a6b8c0d
Compare
|
I've dropped the commit adding it to the default layouts. Users will have to explicitly add the key to their layout if desired. |
jackpot51
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a FnLock toggle and a custom key for it.
F1-F12behave normallyF1-F12behave as the alternate functionSet it to
Fn+Escby default.NOTE: Holding
Fn+Escat power on (S5 to S0) is used for resetting the EC configs. After S0,Fn+Escwill only act as FnLock.NOTE: System76 laptops do not have an indicator for FnLock state.
Resolves: system76/firmware-open#78