kbc: Add reset function

This function can be called after EC init to put the KBC into a known working state. Signed-off-by: Tim Crawford <[email protected]>
system76 · Jul 22, 2023 · de546fa · de546fa
1 parent 0d83819
commit de546fa
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/src/board/system76/common/include/board/kbc.h b/src/board/system76/common/include/board/kbc.h
@@ -10,6 +10,7 @@
 extern uint8_t kbc_leds;
 
 void kbc_init(void);
+void kbc_reset(void);
 bool kbc_scancode(uint16_t key, bool pressed);
 void kbc_event(struct Kbc *kbc);
 

diff --git a/src/board/system76/common/kbc.c b/src/board/system76/common/kbc.c
@@ -18,6 +18,11 @@ void kbc_init(void) {
     // Set IRQ mode to level-triggered
     *(KBC.irq) = 0;
 #endif
+
+    kbc_reset();
+}
+
+void kbc_reset(void) {
     // Set "key lock" to disabled
     *(KBC.status) = BIT(4);
 }

diff --git a/src/ec/ite/include/ec/kbc.h b/src/ec/ite/include/ec/kbc.h
@@ -8,8 +8,6 @@
 #include <stdbool.h>
 #include <stdint.h>
 
-void kbc_init(void);
-
 struct Kbc {
     // Control register
     volatile uint8_t *control;