addw4: Fix USB

system76 · Feb 13, 2024 · 076fd32 · 076fd32
1 parent 1be392e
commit 076fd32
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/board/system76/addw4/gpio.c b/src/board/system76/addw4/gpio.c
@@ -63,7 +63,8 @@ void gpio_init(void) {
     GPDRC = 0;
     // VGA_HEATSINK_SW
     GPDRD = BIT(3);
-    GPDRE = 0;
+    // USB_PWR_EN#
+    GPDRE = BIT(3);
     GPDRF = 0;
     // H_PROCHOT_EC, BL_PWM_EN_EC
     GPDRG = BIT(6) | BIT(0);
@@ -148,7 +149,7 @@ void gpio_init(void) {
     GPCRE1 = GPIO_OUT | GPIO_UP;
     // RGBKB-DET#
     GPCRE2 = GPIO_IN | GPIO_UP;
-    // USB_PWR_EN#
+    // USB_PWR_EN# (XXX: Active high, despite pin name)
     GPCRE3 = GPIO_OUT;
     // DD_ON
     GPCRE4 = GPIO_OUT | GPIO_DOWN;