Bring up Linux kernel #508
Draft
+816
−94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChinYikMing
force-pushed
the
feat/bring-up-linux
branch
from
b21d054
to
fd87884
Compare
jserv
reviewed
Oct 28, 2024
There was a problem hiding this comment.
Benchmarks
| Benchmark suite | Current: cfb3c3a | Previous: 84ea32f | Ratio |
|---|---|---|---|
Dhrystone |
1526 Average DMIPS over 10 runs |
1535 Average DMIPS over 10 runs |
1.01 |
Coremark |
1434.13 Average iterations/sec over 10 runs |
1403.237 Average iterations/sec over 10 runs |
0.98 |
This comment was automatically generated by workflow using github-action-benchmark.
jserv
reviewed
Oct 28, 2024
jserv
reviewed
Oct 28, 2024
| @@ -922,9 +922,7 @@ static inline bool op_misc_mem(rv_insn_t *ir, const uint32_t insn) | |||
| * FENCE FM[3:0] pred[3:0] succ[3:0] rs1 000 rd 0001111 | |||
| * FENCEI imm[11:0] rs1 001 rd 0001111 | |||
| */ | |||
|
|
|||
There was a problem hiding this comment.
Don't do this. Minimize the necessary changes.
jserv
reviewed
Oct 28, 2024
| @@ -90,7 +90,7 @@ enum op_field { | |||
| ) \ | |||
| /* RV32 Zicsr Standard Extension */ \ | |||
| IIF(RV32_HAS(Zicsr))( \ | |||
| _(csrrw, 0, 4, 0, ENC(rs1, rd)) \ | |||
| _(csrrw, 1, 4, 0, ENC(rs1, rd)) \ | |||
There was a problem hiding this comment.
If SYSTEM configuration is set, the Zicsr should be set accordingly.
|
Can you exploit the prebuilt image files used by semu? |
Yes, intended. Ultimately, the Image in current build directory will be removed. |
jserv
requested changes
Oct 28, 2024
This comment was marked as outdated.
This comment was marked as outdated.
ChinYikMing
commented
Nov 1, 2024
jserv
reviewed
Nov 1, 2024
|
Consider to use recent clang for static analysis in CI pipeline: (maybe another pull request) --- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -139,16 +139,17 @@ jobs:
- name: set up scan-build
run: |
sudo apt-get update -q -y
- sudo apt-get install -q -y clang clang-tools libsdl2-dev libsdl2-mixer-dev
+ sudo apt-get install -q -y libsdl2-dev libsdl2-mixer-dev
wget https://apt.llvm.org/llvm.sh
chmod +x ./llvm.sh
sudo ./llvm.sh 18
+ sudo apt-get install -q -y clang-18 clang-tools-18
shell: bash
- name: run scan-build without JIT
- run: make distclean && scan-build -v -o ~/scan-build --status-bugs --use-cc=clang --force-analyze-debug-code --show-description -analyzer-config stable-report-filename=true -enable-checker valist,nullability make ENABLE_EXT_F=0 ENABLE_SDL=0 ENABLE_JIT=0
+ run: make distclean && scan-build-18 -v -o ~/scan-build --status-bugs --use-cc=clang-18 --force-analyze-debug-code --show-description -analyzer-config stable-report-filename=true -enable-checker valist,nullability make ENABLE_EXT_F=0 ENABLE_SDL=0 ENABLE_JIT=0
- name: run scan-build with JIT
run: |
- make ENABLE_JIT=1 distclean && scan-build -v -o ~/scan-build --status-bugs --use-cc=clang --force-analyze-debug-code --show-description -analyzer-config stable-report-filename=true -enable-checker valist,nullability make ENABLE_EXT_F=0 ENABLE_SDL=0 ENABLE_JIT=1
+ make ENABLE_JIT=1 distclean && scan-build-18 -v -o ~/scan-build --status-bugs --use-cc=clang-18 --force-analyze-debug-code --show-description -analyzer-config stable-report-filename=true -enable-checker valist,nullability make ENABLE_EXT_F=0 ENABLE_SDL=0 ENABLE_JIT=1
compliance-test:
needs: [detect-code-related-file-changes] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build
rv32emuwithENALBE_SYSTEMconfig:Then, boot Linux kernel by following: