Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress Cppcheck constant check #154

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Suppress Cppcheck constant check #154

merged 1 commit into from
Feb 27, 2024

Conversation

25077667
Copy link
Contributor

@25077667 25077667 commented Feb 21, 2024

Refine the pre-commit hook to enforce a minimum Cppcheck Version of 1.90, alerting users with an error message and guidance on compiling Cppcheck from source if their version is outdated.

Additionally, upgrade the hook to include the
"--check-level=exhaustive" option for Cppcheck versions 2.11 and above, ensuring a comprehensive analysis.
This adjustment caters to the enhanced capabilities available from version 2.11, promoting more detailed code quality checks.

Eliminate the "--check-level=" is needed after 2.11.
#153

scripts/pre-commit.hook Outdated Show resolved Hide resolved
scripts/pre-commit.hook Outdated Show resolved Hide resolved
Copy link
Contributor

@jserv jserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve git commit message to reflect what you proposed to change.

@25077667 25077667 changed the title Fix pre-commit hook for Cppcheck exhaustive checks Suppress constant checking in queue c for cppcheck Feb 23, 2024
@25077667
Copy link
Contributor Author

@jserv What's about this title?

@jserv jserv changed the title Suppress constant checking in queue c for cppcheck Suppress Cppcheck constant check Feb 23, 2024
Copy link
Contributor

@jserv jserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make git commit message informative.

@25077667
Copy link
Contributor Author

@jserv Is this okay? "Suppress Cppcheck constant check"

@jserv
Copy link
Contributor

jserv commented Feb 25, 2024

@jserv Is this okay? "Suppress Cppcheck constant check"

The subject is acceptable, but there is no commit message body.

@jserv jserv merged commit 3aa0d55 into sysprog21:master Feb 27, 2024
1 of 2 checks passed
fennecJ pushed a commit to fennecJ/lab0-c that referenced this pull request Mar 3, 2024
Refine the pre-commit hook to enforce a minimum Cppcheck version of
1.90, alerting users with an error message and providing guidance on
compiling Cppcheck from source if their version is outdated.

Additionally, upgrade the hook for "--check-level=exhaustive" option
against Cppcheck versions 2.11 and above, ensuring a comprehensive
analysis. This adjustment leverages the enhanced capabilities
available from version 2.11, promoting more detailed code quality
checks.
YiChiChao pushed a commit to YiChiChao/lab0-c that referenced this pull request Mar 15, 2024
Refine the pre-commit hook to enforce a minimum Cppcheck version of
1.90, alerting users with an error message and providing guidance on
compiling Cppcheck from source if their version is outdated.

Additionally, upgrade the hook for "--check-level=exhaustive" option
against Cppcheck versions 2.11 and above, ensuring a comprehensive
analysis. This adjustment leverages the enhanced capabilities
available from version 2.11, promoting more detailed code quality
checks.
Han1018 pushed a commit to Han1018/lab0-c that referenced this pull request Mar 21, 2024
Refine the pre-commit hook to enforce a minimum Cppcheck version of
1.90, alerting users with an error message and providing guidance on
compiling Cppcheck from source if their version is outdated.

Additionally, upgrade the hook for "--check-level=exhaustive" option
against Cppcheck versions 2.11 and above, ensuring a comprehensive
analysis. This adjustment leverages the enhanced capabilities
available from version 2.11, promoting more detailed code quality
checks.
ssheep773 pushed a commit to ssheep773/lab0-c that referenced this pull request Mar 21, 2024
Refine the pre-commit hook to enforce a minimum Cppcheck version of
1.90, alerting users with an error message and providing guidance on
compiling Cppcheck from source if their version is outdated.

Additionally, upgrade the hook for "--check-level=exhaustive" option
against Cppcheck versions 2.11 and above, ensuring a comprehensive
analysis. This adjustment leverages the enhanced capabilities
available from version 2.11, promoting more detailed code quality
checks.
Libright1558 pushed a commit to Libright1558/lab0-c that referenced this pull request Mar 24, 2024
Refine the pre-commit hook to enforce a minimum Cppcheck version of
1.90, alerting users with an error message and providing guidance on
compiling Cppcheck from source if their version is outdated.

Additionally, upgrade the hook for "--check-level=exhaustive" option
against Cppcheck versions 2.11 and above, ensuring a comprehensive
analysis. This adjustment leverages the enhanced capabilities
available from version 2.11, promoting more detailed code quality
checks.
RRbell1027 pushed a commit to RRbell1027/lab0-c that referenced this pull request Mar 25, 2024
Refine the pre-commit hook to enforce a minimum Cppcheck version of
1.90, alerting users with an error message and providing guidance on
compiling Cppcheck from source if their version is outdated.

Additionally, upgrade the hook for "--check-level=exhaustive" option
against Cppcheck versions 2.11 and above, ensuring a comprehensive
analysis. This adjustment leverages the enhanced capabilities
available from version 2.11, promoting more detailed code quality
checks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants