-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for WIF based auth to Webhook Datasource module #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravinadhruve10
commented
Feb 28, 2024
ravinadhruve10
commented
Feb 29, 2024
Change summary: ----------------- To add auth support for validating cloud ingestion resources :- - Adding the support for creating WIF resources with AWS provider. - Allowing external trusted identity to be able to impersonate the SA and use temporary service tokens for authentication. This is to allow Sysdig backend to be able to talk to GCP to access and read the cloud resources. - Using assumed role attribute as the signature for trusted identity. - Creating and binding a custom role to the SA, with just the right set of permissions to read data ingestion cloud resources. - Updating the module outputs with the fields to pass in as metadata to Sysdig backend to do the auth.
ravinadhruve10
force-pushed
the
cdr-validation-support
branch
from
March 7, 2024 23:38
0a1ebf1
to
f82bf30
Compare
mdkulkarni15
reviewed
Mar 8, 2024
mdkulkarni15
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary:
To add auth support for validating cloud ingestion resources :-