fix flush command handling and Windows PNP ID regex #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thingersoft
changed the title
thingersoft
force-pushed
the
master
branch
4 times, most recently
from
6277f19
to
595fc8a
Compare
thingersoft
changed the title
|
These are small changes so I combined both fixes into a single PR. |
|
So far this looks good. Generally I’d prefer them to be split but in this case it’ll be fine I’m sure. I like the flush handling. I want to verify that works well with file sending (it should cancel the file send), which is a loosely related problem. |
|
Hello, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5, fixes #6