Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage #55

Merged
merged 8 commits into from
Mar 1, 2019
Merged

Improve test coverage #55

merged 8 commits into from
Mar 1, 2019

Conversation

asmeurer
Copy link
Member

@asmeurer asmeurer commented Mar 1, 2019

See #47. Coverage may still be improvable in some places.

Also fixes some bugs:

  • fix_authors.py wasn't including a closing parenthesis
  • The bot now always includes the person who opened the pull request in the authors list. Previously this was only done if all the commits had no login information, but if there were commits from someone else as well, it wasn't included.
  • Minor error message improvement when there are no release notes found

asmeurer added 8 commits March 1, 2019 15:51
Also improve the error message for non-release notes added.
And make sure it is also does nothing for edits and synchronization regardless
whether the PR has been merged.
Otherwise a PR by someone commits without a login, plus commits from someone else
won't credit the person who opened the PR. Making a PR from someone else's
branch without adding commits to it is rare.
@asmeurer asmeurer merged commit 2e241e1 into master Mar 1, 2019
@asmeurer asmeurer deleted the test-coverage branch March 1, 2019 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant