Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logger] [Logging] Add references to the ConsoleLogger #20583

Merged
merged 1 commit into from
Jan 22, 2025
Merged

[Logger] [Logging] Add references to the ConsoleLogger #20583

merged 1 commit into from
Jan 22, 2025

Conversation

phansys
Copy link
Contributor

@phansys phansys commented Jan 18, 2025

@phansys phansys marked this pull request as ready for review January 18, 2025 05:10
@carsonbot carsonbot added this to the 7.1 milestone Jan 18, 2025
@MrYamous
Copy link
Contributor

Hi ! Can this be applied to version 6.4?

@phansys
Copy link
Contributor Author

phansys commented Jan 18, 2025

Hi ! Can this be applied to version 6.4?

The merge process should apply these changes in newer branches, including 6.4.

@javiereguiluz javiereguiluz modified the milestones: 7.1, 6.4 Jan 20, 2025
@javiereguiluz javiereguiluz changed the base branch from 7.1 to 6.4 January 22, 2025 09:28
@javiereguiluz javiereguiluz merged commit 76cf7a2 into symfony:6.4 Jan 22, 2025
3 checks passed
@phansys phansys deleted the logging branch January 22, 2025 09:30
@javiereguiluz
Copy link
Member

Thanks Javier.

While merging I reverted the minor changes inside the section Logging a Message. They weren't wrong, but I think it's confusing to mention here the other loggers. In the intro section, where I kept all your proposed changes, we already provide links to the Console logger documentation so I think that's enough for it. Thanks!

@carsonbot carsonbot changed the title [Logging] Add references to the ConsoleLogger [Logger] [Logging] Add references to the ConsoleLogger Jan 22, 2025
@phansys
Copy link
Contributor Author

phansys commented Jan 22, 2025

Thank you Javier!
Just for clarification, are older branches than 6.4 not maintained anymore?

symfony-docs/README.md

Lines 30 to 31 in 31938ea

> Use `5.4` branch as the base of your pull requests, unless you are documenting a
> feature that was introduced *after* Symfony 5.4 (e.g. in Symfony 7.1).

Depending on your answer, I think we should update the instructions at README.md.

@javiereguiluz
Copy link
Member

@phansys yes! Here you can see the currently maintained branches: https://symfony.com/releases#maintained-symfony-branches

@phansys phansys mentioned this pull request Jan 22, 2025
Merged
javiereguiluz added a commit that referenced this pull request Jan 23, 2025
@javiereguiluz
minor #20595 Bump lowest maintained version to 6.4 (phansys)
99c235d 
This PR was merged into the 6.4 branch.

Discussion
----------

Bump lowest maintained version to 6.4

See #20583 (comment).

Commits
-------

698c0e7 Bump lowest maintained version to 6.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrYamous MrYamous MrYamous approved these changes

@javiereguiluz javiereguiluz javiereguiluz approved these changes

Assignees
No one assigned
Labels
Logger Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
4 participants
@phansys @MrYamous @javiereguiluz @carsonbot