Skip to content

Commit

Permalink
minor #508 Require iconv for mbstring (jaapio)
Browse files Browse the repository at this point in the history
This PR was merged into the 1.x branch.

Discussion
----------

Require iconv for mbstring

As the mbstring polyfill using the iconv functions a lot, if not in all calls being done, code without iconv using this polyfill will break.

As this repo also provides a polyfill for iconv I don't think this will be a breaking change.

Commits
-------

bf69c92 Require iconv for mbstring
  • Loading branch information
stof committed Dec 23, 2024
2 parents d7e262e + bf69c92 commit 9f5b48e
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/Mbstring/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@
}
],
"require": {
"php": ">=7.2"
"php": ">=7.2",
"ext-iconv": "*"
},
"provide": {
"ext-mbstring": "*"
Expand Down

0 comments on commit 9f5b48e

Please sign in to comment.