fix: error when type is module #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
linesoft2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The code packaged by fast-glob uses CommonJS to reference the path module, while tsup, which uses esbuild, replaces
requirewith the__requireshim in the generated .mjs file. When a built-in Node module is referenced, an error such asError: Dynamic require of 'path' is not supportedwill occur. To solve this problem, you can add a banner to tsup's options, and for specific changes, please refer to File Change.Linked Issues
#2
Additional context
require()calls of Node built-ins to import statements when emitting ESM for Node evanw/esbuild#2067I'm sorry, please forgive me. 🙏