Fix UTM Utils and Get Tests to Build in ROS 2 #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ewhere causing existing test to fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made some changes to the use of
PROJinutm_utils.cpp, as a team member had noticed that there were problems with thetoLatLon()calculations.I also added the tests back in for ROS 2 (with some of this work having been done by @rjb0026). Some of the transform manager tests are failing, but the plan is that corrections to the relevant source code can be made in a separate PR.
In order to port the
initialize_originpython tests to ROS 2, I installed a pip module and the external tf_transformations ROS 2 package so that the ROS 2 version ofquaternion_to_euler()could be used. If we want to avoid such external dependencies, I can attempt to do those calculations another way. (This package also might only be available as of Humble, so it wouldn't work in EOL distros.)