Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(styles): implement v2 styles for checkbox, radio-button & switch using tokens #3965

Open
wants to merge 127 commits into
base: main
Choose a base branch
from
Open

feat(styles): implement v2 styles for checkbox, radio-button & switch using tokens #3965

wants to merge 127 commits into from

Conversation

schaertim
Copy link
Contributor

No description provided.

schaertim and others added 30 commits September 10, 2024 15:22
@schaertim
Squashed commit of the following:
846df53 
commit 8825864
Author: Tim Schär <[email protected]>
Date:   Tue Sep 10 15:22:04 2024 +0200

    fix(setup): build tokens before styles is started
@schaertim
chore(styles): started adapting styles to use tokens
4fcf664
@schaertim
chore(styles): try to match design
9fbb62f
@schaertim
chore(setup): removed token build from docs:start
b9f1095
@schaertim
chore(docs): added changeset
4bea63d
@schaertim
chore(styles): Implemented most v2 styles
cc40f10
@schaertim
chore(styles): added disabled border styling
5855373
@schaertim
Merge branch '3273-component-checkbox' of https://github.com/swisspos…
d720c9b 
…t/design-system into 3273-component-checkbox
@schaertim
Merge branch 'main' into 3273-component-checkbox
695aae5
@schaertim
chore(styles): removed background-image borders
906b4a9
@schaertim
Merge branch 'main' into 3275-component-switch
c9f2217
@schaertim
Merge branch 'main' into 3275-component-switch
7799866
@schaertim
chore(styles): used reworked tokens
33f964c
@schaertim
feat(styles): extended focus-style mixin
ae4e861
@schaertim
Merge branch '3587-extend-focus-style-mixin-by-adding-optional-params…
7119f37 
…-for-focus-ring-styling' into 3275-component-switch
@schaertim
chore(styles): added focus ring tokens
c8d1906
@schaertim
Delete .changeset/cuddly-panthers-tickle.md
8c83865
@schaertim
chore(styles): added additional param for outline style
06cc569
@schaertim
Merge branch '3587-extend-focus-style-mixin-by-adding-optional-params…
1e0105d 
…-for-focus-ring-styling' of https://github.com/swisspost/design-system into 3587-extend-focus-style-mixin-by-adding-optional-params-for-focus-ring-styling
@schaertim
Merge branch '3587-extend-focus-style-mixin-by-adding-optional-params…
d9234d3 
…-for-focus-ring-styling' into 3275-component-switch
@schaertim
chore(styles): centered switch and added last missing token
1b5e0cf
@schaertim
Merge branch 'main' into 3273-component-checkbox
567b410
@gfellerph
Merge branch 'main' into 3275-component-switch
3d8085c
@schaertim
chore(styles): started implementing tokens for checkboxes
2e663b0
@schaertim
Merge branch 'main' into 3273-component-checkbox
9106713
@schaertim
chore(styles): utilise more tokens
994a1e9
@schaertim @alizedebray
Update .changeset/dull-zoos-whisper.md
d35d080 
Co-authored-by: Alizé Debray <[email protected]>
@schaertim
chore(styles): implemented PR feedback
6096c76
@schaertim @alizedebray
Update packages/styles/src/functions/_forms.scss
9430d01 
Co-authored-by: Alizé Debray <[email protected]>
@schaertim @alizedebray
Update packages/styles/src/variables/components/_form-check.scss
70d02c6 
Co-authored-by: Alizé Debray <[email protected]>
@schaertim
Copy link
Contributor Author

E2E test for the card-control currently fail. The issue is that some tests use a fixture file which needs to load the styles file and the fonts. The fonts however are not able to be loaded due to proxy problems. After discussing this with philipp we decided to postpone finding a solution for this so the PR can be reviewed and merged.

Some of the spacing styles of the radio-button and the checkbox within fieldsets is not looking like the design right now. This is due to some styling having to be done in the fieldset styles instead of the checkbox/radio styles. A ticket to do this has been created.

@schaertim schaertim self-assigned this Nov 12, 2024
@schaertim schaertim marked this pull request as ready for review November 12, 2024 15:52
@schaertim schaertim requested review from a team as code owners November 12, 2024 15:52
This was linked to issues Nov 14, 2024
[component]: Checkbox #3273
Open
[component]: Radio button #3274
Open
[component]: Radio Button (rework) #3537
Open
[component]: Switch #3275
Open
gfellerph
gfellerph requested changes Nov 14, 2024
View reviewed changes
.changeset/chatty-kiwis-travel.md Outdated Show resolved Hide resolved
.changeset/slimy-singers-wonder.md Outdated Show resolved Hide resolved
.changeset/dull-zoos-whisper.md Outdated Show resolved Hide resolved
packages/styles/src/components/checkbox.scss Show resolved Hide resolved
packages/styles/src/components/checkbox.scss Show resolved Hide resolved
packages/styles/src/components/checkbox.scss Show resolved Hide resolved
packages/styles/src/components/radio-button.scss Outdated Show resolved Hide resolved
packages/styles/src/components/switch.scss Outdated Show resolved Hide resolved
packages/styles/src/elements/reset.scss Show resolved Hide resolved
packages/styles/src/components/_form-check.scss Outdated Show resolved Hide resolved
@socket-security Socket Security
Copy link

socket-security bot commented Nov 14, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] Transitive: environment, filesystem, shell, unsafe +30 1.76 MB simenb

View full report↗︎

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfellerph gfellerph gfellerph requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@schaertim schaertim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[component]: Radio Button (rework) [component]: Switch [component]: Radio button [component]: Checkbox
4 participants
@schaertim @swisspost-bot @gfellerph @alizedebray