feat(component): text input #3946
Conversation
🦋 Changeset detectedLatest commit: 5d5b86a The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Related Previews |
There was a problem hiding this comment.
Nice job 👍
Can you just check the animation with the design team? We don't have real requirements for animations right now but for a short amount of time the label appears on top of the placeholder and it feels strange.
Otherwise everything looks fine and is a lot cleaner, thanks!
| }, | ||
| }, | ||
| args: { | ||
| label: 'Label', | ||
| floatingLabel: false, | ||
| floatingLabel: true, |
There was a problem hiding this comment.
Can you please check if we still need the non-floating label and if so if it should be tokenized?
There was a problem hiding this comment.
It would be good to refactor the file structure to match with Figma as we did with other components.
The text input should have its own file and contain the styles of its floating label.
There was a problem hiding this comment.
I created a separate ticket for that: #4000
| border-color: forms.$input-color; | ||
| background-color: forms.$input-bg; | ||
| border-color: tokens.get('input-color-enabled-border'); | ||
| background-color: tokens.get('input-color-enabled-bg'); | ||
| } | ||
|
|
||
| &[type='file'] { |
There was a problem hiding this comment.
The value is not correctly aligned for the file input.
There was a problem hiding this comment.
I created a separate ticket for that: #4001
|
No description provided.