Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(styles): create blockquote component #3882

Open
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

myrta2302
Copy link
Contributor

No description provided.

@myrta2302 myrta2302 linked an issue Nov 5, 2024 that may be closed by this pull request
1 task
Copy link

changeset-bot bot commented Nov 5, 2024

🦋 Changeset detected

Latest commit: 6f5a7ff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@swisspost/design-system-documentation Patch
@swisspost/design-system-styles Patch
@swisspost/design-system-components-angular-workspace Patch
@swisspost/design-system-components Patch
@swisspost/internet-header Patch
@swisspost/design-system-intranet-header-workspace Patch
@swisspost/design-system-nextjs-integration Patch
@swisspost/design-system-styles-primeng-workspace Patch
@swisspost/design-system-intranet-header Patch
@swisspost/design-system-styles-primeng Patch
@swisspost/design-system-components-react Patch
@swisspost/design-system-components-angular Patch
@swisspost/design-system-intranet-header-showcase Patch
@swisspost/design-system-tokens Patch
@swisspost/design-system-icons Patch
@swisspost/design-system-migrations Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Nov 5, 2024

Related Previews

@myrta2302 myrta2302 marked this pull request as ready for review November 11, 2024 10:52
@myrta2302 myrta2302 requested review from a team as code owners November 11, 2024 10:52
Copy link
Contributor

@alizedebray alizedebray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the previous version, the quotes character was different depending on the language: https://design-system.post.ch/?path=/docs/a4c7d5fa-9f8d-4a95-820b-ae4ce9ab4f03--docs.

This is not the case anymore. Is that intentional?

.changeset/twenty-items-drum.md Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Nov 14, 2024

Copy link
Contributor

@alizedebray alizedebray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked out your branch and tested the blockquotes locally on Firfox and I still cannot see the quote character changing depending on the language.

@myrta2302
Copy link
Contributor Author

myrta2302 commented Nov 15, 2024

I checked out your branch and tested the blockquotes locally on Firfox and I still cannot see the quote character changing depending on the language.

Hey! So i notice the following regarding the Language dependent quotes :

  1. Localhost Styles:Playground -> work on Edge/Chrome and Firefox.
  2. Localhost Documentation -> work only on Edge/Chrome.
  3. Branch Preview -> work only on Edge/Chrome.
  4. (v8.5) Published Documentation -> work partially on Edge/Chrome and Firefox. They change only from " to « (missing 'de' version)

@gfellerph gfellerph removed their request for review November 15, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[component]: Blockquotes
3 participants