-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(styles): update select disabled styles #3228
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the styles to match Figma? When the selection is disabled:
- the label and hint should be
--post-gray-60
- the chevron icon should be
--post-gray-40
- the text should be
--post-gray-60
and not strikethrough
The Design in Figma is already updated and the text is now strikethrough also in the select. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you declare the variables like so:
$input-disabled-color: var(--post-gray-60);
$input-disabled-border-color: var(--post-gray-40);
Then the other files can remain unchanged, still using forms.$input-disabled-color
and forms.$input-disabled-border-color
The only place where you will have to declare the gray manually is here, because you cannot use a var() in a background URL:
$form-select-disabled-color: forms.$input-disabled-color;
$form-select-indicator-disabled: url('#{icons.get-colored-svg-url('2113', $form-select-disabled-color)}') !default;
This approach helps with consistency as you only define the gray twice: once in the form variables and once in the select background.
Co-authored-by: Alizé Debray <[email protected]>
Co-authored-by: Alizé Debray <[email protected]>
@alizedebray the svg doesn't work if there is a css variable behind the sass variable, so I just put a color sass variable for the background URL. |
Quality Gate passedIssues Measures |
No description provided.