Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(documentation): add version switch active state to v6 #3049

Merged
merged 30 commits into from
Jul 15, 2024

Conversation

davidritter-dotcom
Copy link
Contributor

@davidritter-dotcom davidritter-dotcom commented May 2, 2024

Depends on the following PRs:

@davidritter-dotcom davidritter-dotcom requested a review from a team as a code owner May 2, 2024 10:36
Copy link

changeset-bot bot commented May 2, 2024

🦋 Changeset detected

Latest commit: fb11c82

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@swisspost/design-system-documentation Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

sonarcloud bot commented May 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@gfellerph
Copy link
Member

@davidritter-dotcom and @oliverschuerch, that won't work. The workflows are not in place to release older versions yet. You can still merge it and as soon as the workflows work again, it's going to be released (or you could release manually).

@oliverschuerch
Copy link
Contributor

oliverschuerch commented May 30, 2024

The PR is up to date and I deployed the storybook output from it manually to https://design-system-version-6.netlify.app.
There is a problem with some blocked assets, which get blocked.
I've created also a PR to change the current v6 url to the one mentioned above, so the version switcher can point to the new netlify page.

@oliverschuerch oliverschuerch added on hold Wait for something to be done, before continue working on this Issue 🚂 PR train PR which follows another one. labels Jun 4, 2024
@swisspost-bot
Copy link
Contributor

swisspost-bot commented Jul 12, 2024

Related Previews

@oliverschuerch oliverschuerch self-assigned this Jul 12, 2024
# Conflicts:
#	.github/actions/setup-pnpm/action.yaml
@oliverschuerch oliverschuerch removed the on hold Wait for something to be done, before continue working on this Issue label Jul 15, 2024
@oliverschuerch oliverschuerch requested review from alizedebray and oliverschuerch and removed request for oliverschuerch and alizedebray July 15, 2024 12:14
@oliverschuerch oliverschuerch merged commit fcff18e into release/v6 Jul 15, 2024
7 checks passed
@oliverschuerch oliverschuerch deleted the 2973-v6-version-switch-active-state branch July 15, 2024 12:24
oliverschuerch pushed a commit that referenced this pull request Jul 18, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to release/v6, this
PR will be updated.


# Releases
## @swisspost/[email protected]

### Patch Changes

- Updated netlify site configuration for v6 docs (by
[@gfellerph](https://github.com/gfellerph) with
[#2985](#2985))

- Fixed version-switcher to show the same way like on
design-system.post.ch. (by
[@davidritter-dotcom](https://github.com/davidritter-dotcom) with
[#3049](#3049))

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚂 PR train PR which follows another one.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants