chore(components): export accordion, popover and popovercontainer #2424
Conversation
|
|
|
Preview environment ready: https://preview-2424--swisspost-design-system-next.netlify.app |
| export { PostAlert } from './components/post-alert/post-alert'; | ||
| export { PostCollapsible } from './components/post-collapsible/post-collapsible'; | ||
| export { PostIcon } from './components/post-icon/post-icon'; | ||
| export { PostPopover } from './components/post-popover/post-popover'; | ||
| export { PostPopovercontainer } from './components/post-popovercontainer/post-popovercontainer'; |
There was a problem hiding this comment.
@oliverschuerch This is actually an undocumented (internal) component, should it still be exported here?
There was a problem hiding this comment.
In general, I would say "no".
But as long as stencil is generating the types for this component and putting them in the components.d.ts file, we need to export all the components. Otherwise we will not be able to release a bug-free components-angular package.
I have created a ticket to address this problem: #2426.
| export { PostAlert } from './components/post-alert/post-alert'; | ||
| export { PostCollapsible } from './components/post-collapsible/post-collapsible'; | ||
| export { PostIcon } from './components/post-icon/post-icon'; | ||
| export { PostPopover } from './components/post-popover/post-popover'; | ||
| export { PostPopovercontainer } from './components/post-popovercontainer/post-popovercontainer'; |
There was a problem hiding this comment.
In general, I would say "no".
But as long as stencil is generating the types for this component and putting them in the components.d.ts file, we need to export all the components. Otherwise we will not be able to release a bug-free components-angular package.
I have created a ticket to address this problem: #2426.
alizedebray
deleted the
2408-add-popover-and-popovercontainer-to-exported-members-in-the-components-package
branch
No description provided.