feat(documentation): adds open graph tags to storybook header #2205
Conversation
|
|
Preview environment ready: https://preview-2205--swisspost-design-system-next.netlify.app |
There was a problem hiding this comment.
I think we should use a different image as the preview. The one used now has overflowing text: https://www.opengraph.xyz/url/https%3A%2F%2Fpreview-2205--swisspost-design-system-next.netlify.app%2F
Here's a collection of splash screen variants, recommended is an image in the format 1200x630.
adds height, width and alt for og:image
|
I made the image be a reference to our github code repository becasue a relative path cannot be used in the url. This should work in theory. However it cannot yet work in this preview as there is no image in the location atm as it would be added by this PR as well. I just realised It would probably better to convert the image to a datatype so it has a smaller file size an svg would be ideal but I do not know how to convert a png to a svg. I mean there are convertors out there but I do not know which ones I am allowed to use. |
You can choose the file type when exporting from figma. I don't know if all services support svg, I'd stick to png. The png can be further optimised by using https://tinypng.com/. |
This reverts commit edbbf2d.
checked the documentation for twitter cards and saw that they had fallbacks on the respective open graph tags.
also adjusts the name of the .png file
|
There is an anomaly. On the frist page of the review the home--docs the open graph tags seem to have no effect.