fix(styles): Small variants for checkbox and radio #2086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0846ef1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Preview environment ready: https://preview-2086--swisspost-web-frontend.netlify.app |
Base automatically changed from
refactor/1916-form-check-remove-boostrap
to
main
October 19, 2023 07:34
# Conflicts: # packages/styles/src/components/form-validation.scss # packages/styles/src/mixins/_form-checks.scss
|
Kudos, SonarCloud Quality Gate passed!
|
imagoiq
requested review from
b1aserlu,
davidritter-dotcom and
a team
as code owners
|
Merge as it was already reviewed in #2067 |
gfellerph
pushed a commit
that referenced
this pull request
Oct 24, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @swisspost/[email protected] ### Minor Changes - Added a new button to clear the text in the search box. (by [@b1aserlu](https://github.com/b1aserlu) with [#2036](#2036)) ### Patch Changes - Added hide-buttons prop to hide all breadcrumbs buttons. (by [@imagoiq](https://github.com/imagoiq) with [#2027](#2027)) - Fixed internet-header search focus truncated on focus-within. (by [@imagoiq](https://github.com/imagoiq) with [#2043](#2043)) - Compressed styles output. (by [@imagoiq](https://github.com/imagoiq) with [#2098](#2098)) - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Fixed misplaced custom icons in “post-alert” elements with actions. (by [@alizedebray](https://github.com/alizedebray) with [#2094](#2094)) - Updated the keyboard navigation on the `post-tabs` component. (by [@alizedebray](https://github.com/alizedebray) with [#2093](#2093)) - Fixed tabs count announcement with VoiceOver. (by [@imagoiq](https://github.com/imagoiq) with [#2047](#2047)) - Compressed styles output. (by [@imagoiq](https://github.com/imagoiq) with [#2098](#2098)) - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Changed the main title of the intranet-header from `<h2>` to `<h1>`. (by [@b1aserlu](https://github.com/b1aserlu) with [#2104](#2104)) - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Refactored the grid-system: adjusted container paddings, added responsive gutter-widths. Updated grid docs. (by [@oliverschuerch](https://github.com/oliverschuerch) with [#2045](#2045)) - Added small variants for checkbox and radio buttons. Lowered font-size of validation blocks for form elements. (by [@imagoiq](https://github.com/imagoiq) with [#2086](#2086)) - Fixed missing active tab border on HTML component. (by [@imagoiq](https://github.com/imagoiq) with [#2037](#2037)) - Fixed active switch control showing a check icon in Chrome. (by [@alizedebray](https://github.com/alizedebray) with [#2090](#2090)) ## @swisspost/[email protected] ### Minor Changes - Added a docs page for our spacing utilities (by [@davidritter-dotcom](https://github.com/davidritter-dotcom) with [#1988](#1988)) - Added a docs page for our grid-system. (by [@oliverschuerch](https://github.com/oliverschuerch) with [#1947](#1947)) ### Patch Changes - Refactored the grid-system: adjusted container paddings, added responsive gutter-widths. Updated grid docs. (by [@oliverschuerch](https://github.com/oliverschuerch) with [#2045](#2045)) - Fixed the "fixed" control in the `post-alert` documentation. (by [@alizedebray](https://github.com/alizedebray) with [#2094](#2094)) - Updated dependencies: - @swisspost/[email protected] - @swisspost/[email protected] - @swisspost/[email protected] - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] - @swisspost/[email protected]
imagoiq
added a commit
that referenced
this pull request
Nov 8, 2023
## What This PR is a bit confusing as it addresses two problems. 1. Checked radio button were creating a visual shift in inline layout. It was fixed with #2086 by using a border instead of a margin. But it created the second following problem. 2. Checked radio button on dark background blends the circle indicator with the background. #2170 Other additions: - Added inline layout to snapshot ## UI ### Before   ### After   --------- Co-authored-by: Philipp Gfeller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same PR as #2067 which was merged too soon.