Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve styles watch performance #1841

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

gfellerph
Copy link
Member

Only copies changed files to dist. This will improve performance for development massively because vite reacted to every change in dist individually and before, every single sass file was copied to dist regardless if it changed or not. Also, map-icons creates a theoretical infinite loop and calling watch again is not necessary within the watch task.

Only copies changed files to dist. This will improve performance for development massively because vite reacted to every change in dist individually and before, every single sass file was copied to dist regardless if it changed or not. Also, map-icons creates a theoretical infinite loop and calling watch again is not necessary within the watch task.
@changeset-bot
Copy link

changeset-bot bot commented Aug 21, 2023

⚠️ No Changeset found

Latest commit: 97758c9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Aug 21, 2023

Preview environment ready: https://preview-1841--swisspost-web-frontend.netlify.app
Preview environment ready: https://preview-1841--swisspost-design-system-next-v7.netlify.app
Preview environment ready: https://preview-1841--swisspost-design-system-next.netlify.app

@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.4% 1.4% Duplication

@gfellerph gfellerph requested a review from imagoiq August 21, 2023 11:31
@gfellerph gfellerph merged commit f123ba2 into main Aug 21, 2023
9 of 11 checks passed
@gfellerph gfellerph deleted the improve-styles-watch-task-for-docs-v7 branch August 21, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants