Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(internet-header): Add toggleOverlayById method #1838

Merged
merged 4 commits into from
Sep 25, 2023

Conversation

imagoiq
Copy link
Contributor

@imagoiq imagoiq commented Aug 21, 2023

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Aug 21, 2023

🦋 Changeset detected

Latest commit: b1867cf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@swisspost/internet-header Minor
@swisspost/design-system-documentation Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@imagoiq imagoiq linked an issue Aug 21, 2023 that may be closed by this pull request
@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Aug 21, 2023

Preview environment ready: https://preview-1838--swisspost-design-system-next-v7.netlify.app
Preview environment ready: https://preview-1838--swisspost-design-system-next.netlify.app

@imagoiq imagoiq added the on hold Wait for something to be done, before continue working on this Issue label Aug 23, 2023
@imagoiq
Copy link
Contributor Author

imagoiq commented Aug 23, 2023

On hold until #1857 and #1855 are merged

@imagoiq imagoiq requested a review from a team as a code owner September 21, 2023 14:10
@imagoiq imagoiq removed the on hold Wait for something to be done, before continue working on this Issue label Sep 21, 2023
@imagoiq imagoiq force-pushed the feat/1379-internet-breadcrumbs-toggleOverlayId branch from d32283c to b1867cf Compare September 25, 2023 06:33
@sonarcloud
Copy link

sonarcloud bot commented Sep 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@imagoiq imagoiq merged commit 01075c7 into main Sep 25, 2023
9 checks passed
@imagoiq imagoiq deleted the feat/1379-internet-breadcrumbs-toggleOverlayId branch September 25, 2023 06:41
gfellerph pushed a commit that referenced this pull request Oct 4, 2023
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @swisspost/[email protected]

### Minor Changes

- Added the `post-tooltip` component. (by
[@gfellerph](https://github.com/gfellerph) with
[#1879](#1879))

- Created the web component variant for the alert component. (by
[@alizedebray](https://github.com/alizedebray) with
[#1085](#1085))

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Minor Changes

- Enabled nesting the header in a different scroll container than the
`<body>` element. The header stickyness and logo animation logic will
automatically attach to the nearest scrolling container instead of the
document when nested in a container that has `overflow: auto | scroll`
set. (by [@alizedebray](https://github.com/alizedebray) with
[#1855](#1855))

- Added ability to toggle programmatically an overlay associated with a
button using the `toggleOverlayById` method. (by
[@imagoiq](https://github.com/imagoiq) with
[#1838](#1838))

### Patch Changes

- Fixed an issue with custom configuration that was not applied when the
prop "language" was not set on the internet header. (by
[@alizedebray](https://github.com/alizedebray) with
[#1855](#1855))
-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

- Removed bound between logo and language to allow any language to
display the logo. (by [@imagoiq](https://github.com/imagoiq) with
[#2009](#2009))
-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

- Removed bound between logo and language to allow any language to
display the logo. (by [@imagoiq](https://github.com/imagoiq) with
[#2009](#2009))

- Reduced the gap between the alert body and action buttons. (by
[@alizedebray](https://github.com/alizedebray) with
[#1085](#1085))

- Removed duplicated close button on toast when using ngx-toastr
programatically. (by [@imagoiq](https://github.com/imagoiq) with
[#2011](#2011))

- Updated and added the gaps between the title and the link-list in the
`.topic-teaser-content` class to comply with the figma design. (by
[@b1aserlu](https://github.com/b1aserlu) with
[#1927](#1927))

- Added missing pointer-events to allow a dismissible toast to be closed
interactively. (by [@imagoiq](https://github.com/imagoiq) with
[#2008](#2008))

- Updated icons to display as mask images, this way their color can be
set by adjusting the CSS `background-color` property. (by
[@alizedebray](https://github.com/alizedebray) with
[#1945](#1945))

## @swisspost/[email protected]

### Minor Changes

- Added the `post-tooltip` component. (by
[@gfellerph](https://github.com/gfellerph) with
[#1879](#1879))

- Integrated the google tag manager and the basic events (page_context,
page_change) to the documentation. (by
[@oliverschuerch](https://github.com/oliverschuerch) with
[#1951](#1951))

- Created the web component variant for the alert component. (by
[@alizedebray](https://github.com/alizedebray) with
[#1085](#1085))

### Patch Changes

- Used the post-icon component instead of `.pi` classes to display icons
in stories. (by [@alizedebray](https://github.com/alizedebray) with
[#1945](#1945))

- Added deprecation alerts for `.form-control-rg`, `.form-control-md`,
`.form-select-rg` and `.form-select-md` form-control variants. (by
[@b1aserlu](https://github.com/b1aserlu) with
[#1882](#1882))

-   Updated dependencies:
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

- Updated the installation intructions for the Intranet Header. (by
[@alizedebray](https://github.com/alizedebray) with
[#1942](#1942))

- Added deprecation alerts for `.form-control-rg`, `.form-control-md`,
`.form-select-rg` and `.form-select-md` form-control variants. (by
[@b1aserlu](https://github.com/b1aserlu) with
[#1882](#1882))

- Fixed ngBootstrap documentation links. (by
[@imagoiq](https://github.com/imagoiq) with
[#1987](#1987))

-   Updated dependencies:
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Triggering contact & help dialogs via events/method calls
4 participants