Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(documentation,internet-header): Clarify and fix internet-header getting started doc #1792

Merged
merged 5 commits into from
Aug 24, 2023
Merged

fix(documentation,internet-header): Clarify and fix internet-header getting started doc #1792

merged 5 commits into from
Aug 24, 2023

Conversation

imagoiq
Copy link
Contributor

@imagoiq imagoiq commented Aug 14, 2023 •
edited
Loading

This is coming from my analysis on #1526 and #1721. Please let me know if something doesn't make sense.

@imagoiq imagoiq self-assigned this Aug 14, 2023
@changeset-bot
Copy link

changeset-bot bot commented Aug 14, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: d4cb4c7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@swisspost/internet-header Patch
@swisspost/design-system-documentation Patch
@swisspost/design-system-documentation-v6 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@imagoiq imagoiq linked an issue Aug 14, 2023 that may be closed by this pull request
Webpack build fails because of source maps #1526
Closed
imagoiq
imagoiq commented Aug 14, 2023
View reviewed changes
packages/documentation/src/stories/internet-header/getting-started.stories.mdx Outdated
Comment on lines 12 to 16
<ul>
<li><a href="#installation" target="_self">Installation</a></li>
<li><a href="#configuration" target="_self">Configuration</a></li>
<li><a href="#help" target="_self">Help</a></li>
</ul>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were redirecting to the iframe.html page. I'll do another to fix them across all doc. Storybook's issue: storybookjs/storybook#15934

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Aug 14, 2023 •
edited
Loading

Preview environment ready: https://preview-1792--swisspost-design-system-next-v7.netlify.app
Preview environment ready: https://preview-1792--swisspost-design-system-next.netlify.app

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Aug 14, 2023 •
edited
Loading

Preview environment ready: https://preview-1792--swisspost-design-system-next.netlify.app

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Aug 14, 2023 •
edited
Loading

Preview environment ready: https://preview-1792--swisspost-design-system-next-v7.netlify.app

@gfellerph gfellerph mentioned this pull request Aug 17, 2023
Closed
@gfellerph gfellerph added the 📦 migrations Related to the @swisspost/design-system-migrations package label Aug 17, 2023
gfellerph
gfellerph requested changes Aug 17, 2023
View reviewed changes
Copy link
Member

@gfellerph gfellerph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge after the switch

@imagoiq imagoiq force-pushed the 1526-doc-internet-header-import branch from d625ce1 to c92ff08 Compare August 22, 2023 06:15
@imagoiq imagoiq requested a review from gfellerph August 22, 2023 06:22
@gfellerph gfellerph requested a review from a team as a code owner August 24, 2023 10:05
@imagoiq imagoiq merged commit 4a93837 into main Aug 24, 2023
7 checks passed
@imagoiq imagoiq deleted the 1526-doc-internet-header-import branch August 24, 2023 10:43
@sonarcloud
Copy link

sonarcloud bot commented Aug 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions github-actions bot mentioned this pull request Aug 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfellerph gfellerph gfellerph approved these changes

@oliverschuerch oliverschuerch Awaiting requested review from oliverschuerch

@alizedebray alizedebray Awaiting requested review from alizedebray

@b1aserlu b1aserlu Awaiting requested review from b1aserlu

@davidritter-dotcom davidritter-dotcom Awaiting requested review from davidritter-dotcom

Assignees

@imagoiq imagoiq

Labels
📦 migrations Related to the @swisspost/design-system-migrations package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Webpack build fails because of source maps
3 participants
@imagoiq @swisspost-bot @gfellerph