-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(styles): update buttons padding, gap and border-radius #1666
Conversation
🦋 Changeset detectedLatest commit: 6a0b5b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Preview environment ready: https://preview-1666--swisspost-design-system-next-v7.netlify.app |
Preview environment ready: https://preview-1666--swisspost-design-system-next.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also update the icon size for large buttons, it is 24px currently instead of 22px in Figma? |
The «Like» Button does not show in any of the Variants. |
I think this one is ready to be merged, if you could have a look, please @gfellerph @alizedebray @oliverschuerch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a changeset please? The rest is looking good to me.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx
Co-authored-by: Alizé Debray <[email protected]>
Following #1571 (comment) and discussion from today.
Updated:
Figma: https://www.figma.com/file/xZ0IW0MJO0vnFicmrHiKaY/Components-Post?node-id=9096%3A36684&mode=dev