-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update d3 dependencies #513
Conversation
@steveblue can you help ? |
@marjan-georgiev can you have a check? |
@jogaj @marjan-georgiev @steveblue can anybody check the PR. I think some people are needing it |
Any status update on this, we're upgrading our Angular version and this is the only thing causing us to use legacy peer deps. And legacy peer deps creates a completely different package-lock.json. It seems a shame this PR has been open for ~3 months with no status updates. Using 3.0 gives us this error
Pointing at this section of code. You can even see the issue using |
Is there any update for this PR? It would be nice to be merged. |
if you need it for security reasons you can try this package: https://www.npmjs.com/package/@kr0san89/ngx-graph/v/9.0.0-next-1 |
Can someone please approve and merge this request please ? We are actually blocked by this. Thanks ! |
Very humble request to @jogaj @marjan-georgiev @steveblue to kindly review and merge @Kr0san89 's PR. We need to push the application to production and it will be nice to have this solution applied rather than applying workarounds for the issue. Thank you ! |
Thank you for the contribution and apologies for the difficulty this has caused. @swimlane/ngx-graph is now on 2.3.0. Can you please sync with master to reflect this change in the package.json? |
Thank you so @steveblue for your attention. @Kr0san89 Kindly requesting you to please sync your branch with master, so that Stephen can merge it. |
There was no conflict so i think rebase was not really necassary, but still i did it. |
Thank you so much @Kr0san89 for this. @steveblue can you please do the needful now ? Thanks ! |
Hi @steveblue @jogaj and @marjan-georgiev . Can you please complete this pull request and release new version for ngx-graph please ? We are actually stuck due to this. Thanks |
d3 dependencies have been upgrade in ngx-graph 9.0.0. Enjoy :) |
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
#500
#496
#495
What is the new behavior?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
no IE, min node v12, maybe other
Other information:
Hard to test would recommend publishing it as some unstable version, so that people can try it