Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aptos protocol in UI and first wallet adapter (Martian wallet) #390

Merged
merged 16 commits into from
Sep 22, 2022
Merged

Aptos protocol in UI and first wallet adapter (Martian wallet) #390

merged 16 commits into from
Sep 22, 2022

Conversation

nicomiicro
Copy link
Contributor

@nicomiicro nicomiicro commented Sep 20, 2022 •
edited
Loading

Notion ticket: https://www.notion.so/exsphere/Aptos-integration-f6daa06ac05b48f490528c38a50ffd88

Checklist

  • Github project and label have been assigned
  • Tests have been added or are unnecessary
  • Docs have been updated or are unnecessary
  • Preview deployment works (visit the Cloudflare preview URL)
  • Manual testing in #product-testing completed or unnecessary
  • New i18n strings do not contain any security vulnerabilities (e.g. should not allow translator to update email/url)
  • When fetching new translations from external sources, do a sanity check (e.g. get people who speak the language to check, shove all new translations into Google translate)

@nicomiicro nicomiicro changed the title Aptos/wallet adapters Aptos protocol in UI and first wallet adapter (Martian wallet) Sep 20, 2022
@nicomiicro nicomiicro added the feature New feature or request label Sep 20, 2022
@nicomiicro nicomiicro self-assigned this Sep 20, 2022
nicomiicro
nicomiicro commented Sep 20, 2022
View reviewed changes
apps/ui/package.json Outdated Show resolved Hide resolved
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 20, 2022 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: eae87c2
Status: ✅  Deploy successful!
Preview URL: https://2285935d.swim-ui.pages.dev
Branch Preview URL: https://aptos-wallet-adapters.swim-ui.pages.dev

View logs

@nicomiicro nicomiicro requested a review from wormat September 20, 2022 13:15
wormat
wormat reviewed Sep 20, 2022
View reviewed changes
Copy link
Collaborator

@wormat wormat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

packages/aptos/src/ecosystem.ts Outdated Show resolved Hide resolved
packages/aptos/src/walletAdapters/BaseAdapter.ts Show resolved Hide resolved
apps/ui/src/config/ecosystem.ts Outdated Show resolved Hide resolved
packages/aptos/src/ecosystem.ts Outdated Show resolved Hide resolved
packages/aptos/src/walletAdapters/MartianWalletAdapter.ts Outdated Show resolved Hide resolved
packages/aptos/src/walletAdapters/MartianWalletAdapter.ts Show resolved Hide resolved
apps/ui/src/hooks/wallets/tests/useWalletAutoConnect.test.ts Outdated Show resolved Hide resolved
@nicomiicro nicomiicro requested a review from wormat September 21, 2022 08:13
@nicomiicro
Copy link
Contributor Author

@wormat does this need any other change/update?

wormat
wormat reviewed Sep 21, 2022
View reviewed changes
Copy link
Collaborator

@wormat wormat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of nits.

packages/aptos/src/walletAdapters/BaseAdapter.ts Outdated Show resolved Hide resolved
apps/ui/src/hooks/wallets/tests/useWalletAutoConnect.test.ts Outdated Show resolved Hide resolved
@nicomiicro
Copy link
Contributor Author

@wormat once this is approved, I will publish packages v0.26.0 for aptos (make it public too) and wormhole changes.

wormat
wormat previously approved these changes Sep 22, 2022
View reviewed changes
Copy link
Collaborator

@wormat wormat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Waiting for info from biz about whether this needs to be secret for now before publishing. If it does then I guess we just merge the changes to the private package and add the UI changes later.

@nicomiicro nicomiicro marked this pull request as ready for review September 22, 2022 10:41
wormat
wormat approved these changes Sep 22, 2022
View reviewed changes
Copy link
Collaborator

@wormat wormat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge pending manual testing.

@github-actions
Copy link

✨ Deployment complete! Take a peek over at https://1d246a8d.ui-storybook.pages.dev

@nicomiicro nicomiicro merged commit d39592a into master Sep 22, 2022
@nicomiicro nicomiicro deleted the aptos/wallet-adapters branch September 22, 2022 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wormat wormat wormat approved these changes

Assignees

@nicomiicro nicomiicro

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicomiicro @wormat