Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use throwsClause #672

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use throwsClause #672

wants to merge 1 commit into from
+4 −4

Conversation

d-date
Copy link

@d-date d-date commented Dec 6, 2023

Replace deprecated property

@allevato
Copy link
Member

allevato commented Dec 6, 2023

Rather than just switch away from the deprecated property, we should consider what kind of breaking we may want inside the clause when a type is given. Without testing it to see what the output would be, I think we'd want to group around the whole throws(...) clause and then add breaks inside the parentheses, in case there's some degenerate situation where the name of the thrown type is extremely long or needs to break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d-date @allevato