Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add curlver.h include to umbrella header to ensure version checks work #5159

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

toffaletti
Copy link
Contributor

@toffaletti toffaletti commented Jan 20, 2025

attempting to fix #5157

I believe the issue is that the version checks here are failing:

#if LIBCURL_VERSION_MAJOR > 7 || (LIBCURL_VERSION_MAJOR == 7 && LIBCURL_VERSION_MINOR > 84) || (LIBCURL_VERSION_MAJOR == 7 && LIBCURL_VERSION_MINOR == 84 && LIBCURL_VERSION_PATCH >= 0)
#define NS_CURL_CURLINFO_CAINFO_SUPPORTED 1
#else
#define NS_CURL_CURLINFO_CAINFO_SUPPORTED 0
#endif

because LIBCURL_VERSION_MAJOR etc have not been defined.
because <curl/curlver.h> hasn't been included anywhere yet.
It is included here, but after CFURLSessionInterface.h has already been processed.

#include "CFURLSessionInterface.h"
#include "CFString.h"
#include <curl/curl.h>

@parkera
Copy link
Contributor

parkera commented Jan 21, 2025

Let us know if this works for you.

@toffaletti
Copy link
Contributor Author

Let us know if this works for you.

I might need your help in understanding how to test this. I haven't built a static sdk from scratch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

swift static sdk: SSL certificate problem: unable to get local issuer certificate
2 participants