add curlver.h include to umbrella header to ensure version checks work #5159
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attempting to fix #5157
I believe the issue is that the version checks here are failing:
swift-corelibs-foundation/Sources/_CFURLSessionInterface/include/CFURLSessionInterface.h
Lines 39 to 43 in c466923
because
LIBCURL_VERSION_MAJOR
etc have not been defined.because
<curl/curlver.h>
hasn't been included anywhere yet.It is included here, but after
CFURLSessionInterface.h
has already been processed.swift-corelibs-foundation/Sources/_CFURLSessionInterface/CFURLSessionInterface.c
Lines 22 to 24 in c466923
swift-corelibs-foundation/Sources/_CFURLSessionInterface/include/static-module.map
Line 2 in c466923