Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only submit password if previous validation completed #375

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mstoeckl
Copy link
Contributor

This should resolve #372; while I'm not entirely satisfied with this solution, I think it is a net improvement.

Commit message:

This averts the risk that one can queue up many password submissions by pressing enter repeatedly (or with key repeat, holding enter), much more quickly than PAM will process them. It may also improve usability by reducing unrevealed system state: now that at most one password can be queued, the "Verifying" message is always shown when a password is being validated.

However, this commit does introduce a minor UI issue: if one types an invalid second password just slightly faster than PAM validation completes, it may fail to submit, and the signs of this may be hard to notice (state transition timing, presence of keypress indicator, and (if enabled) attempt count).

This averts the risk that one can queue up many password submissions
by pressing enter repeatedly (or with key repeat, holding enter),
much more quickly than PAM will process them. It may also improve
usability by reducing unrevealed system state: now that at most one
password can be queued, the "Verifying" message is always shown when
a password is being validated.

However, this commit does introduce a minor UI issue: if one types
an invalid second password just slightly faster than PAM validation
completes, it may fail to submit, and the signs of this may be hard
to notice (state transition timing, presence of keypress indicator,
and (if enabled) attempt count).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Holding Enter key (for example while handling keyboard) queues large number of unlock attempts
1 participant