Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue5165 - SLIP-0039: Shamir's Secret-Sharing for Mnemonic Codes #5174

Merged
merged 31 commits into from
Dec 30, 2022

Conversation

shendel
Copy link
Collaborator

@shendel shendel commented Dec 15, 2022

Checklist

  • I have read the CONTRIBUTING guide
  • Good naming (as clear and simple as possible)
  • Correct behavior if external API endpoints are down, return 404, 504 (or no answer), 401 errors (ddos simulation)
  • I tested desktop/mobile resolution
  • I tested light/dark theme
  • I tested different languages
  • I checked the functionality once again (AFFECT MONEY)
  • I checked the work on the Testnet
  • I checked the work on the Mainnet
  • I checked the work in the plugin
  • I checked the PR once again

Tests

Please start auto tests as follows:

  • add a label swap test to start swap tests
  • add a label withdraw test to start withdraw tests

You can skip these tests if you completely sure that your changes aren't related to this functional

Original issue

#5165

Video / screenshot proof

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Dec 15, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: cec24ca
Status: ✅  Deploy successful!
Preview URL: https://90c37193.multicurrencywallet-btg.pages.dev
Branch Preview URL: https://issue5165.multicurrencywallet-btg.pages.dev

View logs

@noxonsu noxonsu requested a review from Disti4ct December 15, 2022 09:33
@shendel
Copy link
Collaborator Author

shendel commented Dec 16, 2022

В консоле
testSaveShamirsSecrets()
Черновой вариант с кодами

@shendel
Copy link
Collaborator Author

shendel commented Dec 18, 2022

Выбор способа сохранения
image
Сохранение кодов
image
Восстановление из двух кодов
image

@shendel
Copy link
Collaborator Author

shendel commented Dec 18, 2022

#5165

@noxonsu
Copy link
Member

noxonsu commented Dec 27, 2022

мы не можем либы пакетами использовать? 3к втянули зачем

@shendel shendel changed the title (WIP) Issue5165 - SLIP-0039: Shamir's Secret-Sharing for Mnemonic Codes Issue5165 - SLIP-0039: Shamir's Secret-Sharing for Mnemonic Codes Dec 28, 2022
@VitaliyShulik
Copy link
Member

нужно кнопки "позже" и "отмена" во всех модалках сделать серыми а не праймари, как на прикрепленном скриншоте
Screen Shot 2022-12-29 at 16 05 18

@shendel shendel merged commit c86a57a into master Dec 30, 2022
@delete-merged-branch delete-merged-branch bot deleted the issue5165 branch December 30, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants