Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup #4454

Merged
merged 5 commits into from
May 22, 2021
Merged

Cleanup #4454

merged 5 commits into from
May 22, 2021

Conversation

Disti4ct
Copy link
Collaborator

@Disti4ct Disti4ct commented May 22, 2021 •
edited
Loading

Checklist

  • I have read the CONTRIBUTING guide
  • Good naming (as clear and simple as possible)
  • Correct behavior if external API endpoints are down, return 404, 504 (or no answer), 401 errors (ddos simulation)
  • I tested desktop/mobile resolution
  • I tested light/dark theme
  • I tested different languages
  • I checked the functionality once again (AFFECT MONEY)
  • I checked the PR once again

Original issue

#3511
#3125

@Disti4ct Disti4ct changed the title (WIP) Cleanup Cleanup May 22, 2021
@Disti4ct Disti4ct added code health needs review Refactoring Improving and simplifying the code and removed Refactoring Improving and simplifying the code labels May 22, 2021
@sorentobot
Copy link
Collaborator

builded https://testnet4454.swaponline.site https://mainnet4454.swaponline.site

@sorentobot
Copy link
Collaborator

commit bf276f8 rebuilded https://testnet4454.swaponline.site https://mainnet4454.swaponline.site

@noxonsu noxonsu merged commit bf73929 into swaponline:master May 22, 2021
@Disti4ct Disti4ct deleted the codeCleanup branch May 23, 2021 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noxonsu noxonsu noxonsu approved these changes

Assignees
No one assigned
Labels
code health needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Disti4ct @sorentobot @noxonsu