Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) Splash screen: move it into React #4200

Closed
wants to merge 19 commits into from

Conversation

Disti4ct
Copy link
Collaborator

@Disti4ct Disti4ct commented Apr 8, 2021

Checklist

  • I have read the CONTRIBUTING guide
  • Good naming (as clear and simple as possible)
  • Correct behavior if external API endpoints are down, return 404, 504 (or no answer), 401 errors (ddos simulation)
  • I tested desktop/mobile resolution
  • I tested light/dark theme
  • I tested different languages
  • I checked the functionality once again (AFFECT MONEY)
  • I checked the PR once again

Original issue

#4069
#3531
#3511

Video / screenshot proof

videoTestSmall.mp4

Resolutions

320px

320

375px

375

414

414
px

540

540
px

768

768
px

1024

1024
px

@sorentobot
Copy link
Collaborator

@sorentobot
Copy link
Collaborator

@sorentobot
Copy link
Collaborator

@iower
Copy link
Collaborator

iower commented Apr 8, 2021

Thoughts about naming

splash screen = screen with the preloader (see definition)
this screen = screen with these buttons

this naming variants:

  • first screen
  • init screen
  • start screen
  • start page - I think the best one, can be pronounced as стартовая страница or just стартовая. It's as simple as possible, everyone can understand it.

Suggestion

SplashScreen -> StartPage

@sorentobot
Copy link
Collaborator

@sorentobot
Copy link
Collaborator

@noxonsu
Copy link
Member

noxonsu commented Apr 9, 2021

нужно дальше выдрачивать, т.к. это первое впечатление у юзера

  • картинки перенести в прелоадер тогда
  • настройку картинок и текстов вынести в window опции (т.к. захотят их менять клиенты плагинов)

@sorentobot
Copy link
Collaborator

@sorentobot
Copy link
Collaborator

@Disti4ct
Copy link
Collaborator Author

More simple way -> #4212

@Disti4ct Disti4ct closed this Apr 10, 2021
@Disti4ct Disti4ct deleted the splashScreenToReact branch April 13, 2021 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants