Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #3697

Merged
merged 11 commits into from
Dec 2, 2020
Merged

Cleanup #3697

merged 11 commits into from
Dec 2, 2020

Conversation

iower
Copy link
Collaborator

@iower iower commented Nov 28, 2020

Checklist

  • I have read the CONTRIBUTING guide
  • Good naming, keep simple
  • Tested desktop/mobile
  • Tested bright/dark
  • Tested en/ru
  • Affects money; I checked the functionality once again
  • I checked the PR once again

Original issue

#3511

Video / screenshot proof

@sorentobot
Copy link
Collaborator

@sorentobot
Copy link
Collaborator

@sorentobot
Copy link
Collaborator

@sorentobot
Copy link
Collaborator

@sorentobot
Copy link
Collaborator

@sorentobot
Copy link
Collaborator

@sorentobot
Copy link
Collaborator

@sorentobot
Copy link
Collaborator

@iower iower changed the title WIP: Cleanup Cleanup Nov 28, 2020
Copy link
Collaborator

@shendel shendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

,.....

@sorentobot
Copy link
Collaborator

@iower
Copy link
Collaborator Author

iower commented Nov 30, 2020

--- -.- ..--..

import minAmountOffer from 'helpers/constants/minAmountOffer'
import coinsWithDynamicFee from 'helpers/constants/coinsWithDynamicFee'


const mathConstants = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

вынести куданить повыше, может еще где будет использовано

@noxonsu
Copy link
Member

noxonsu commented Dec 1, 2020

нэйминг пула жесть, что проверять??

@noxonsu noxonsu merged commit 0e8329c into master Dec 2, 2020
@delete-merged-branch delete-merged-branch bot deleted the cleanup branch December 2, 2020 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants