Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix imports "moduleResolution": "nodenext" #620

Closed
wants to merge 3 commits into from

Conversation

DetachHead
Copy link

fixes #619

this doesn't really work though because svelte doesn't expose all of these types in its package.json exports. are they intended to be imported by downstream projects like this one? if so, i can make a PR on https://github.com/sveltejs/svelte exposing them

@benmccann
Copy link
Member

The changes to src/utils/id.ts are fine and could be merged, but the changes to src/utils/options.ts would have be reverted since they don't work as you said.

svelte doesn't expose all of these types in its package.json exports. are they intended to be imported by downstream projects like this one? if so, i can make a PR on https://github.com/sveltejs/svelte exposing them

Perhaps @dummdidumm would be able to advise since he's most knowledgeable about the Svelte core types

@bluwy
Copy link
Member

bluwy commented May 12, 2023

Closing until svelte exposes the proper types.

@bluwy bluwy closed this May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compile errors when typechecking svelte.config.js with moduleResolution set to nodenext
3 participants