2024/02/16 迄の更新に追従 #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update README.md * Update +error.svelte * Update +error.svelte * Update README.md
Co-authored-by: Rich Harris <[email protected]>
Co-authored-by: Rich Harris <[email protected]>
It was not clear which page below the layout inherits the data, because in fact it could be any page. The confusion can arise from the way the previous sentence was expressed, as **visually**, there is nothing `below` the layout in the project tree. There are siblings though, like `+page.svelte` but for a Svelte beginner it is **not** immediately obvious that this page also falls `under` the same layout.
…el (sveltejs#443) * docs: apply fail fast for keydown function handler * style: apply fail fast for if condition
* docs: minor addition to onMount usage * Update content/tutorial/01-svelte/07-lifecycle/01-onmount/README.md * Update content/tutorial/01-svelte/07-lifecycle/01-onmount/README.md --------- Co-authored-by: Rich Harris <[email protected]>
…art 3 / Forms / Progressive enhancement (sveltejs#461) * include entire css styles from unsolved code to solved code * slight nitpick; use em dash instead of hyphen for consistency
The readme is missing the line: <div class="centered"> as well as the indentation that are present in the code editor solution. this can cause a slight confusion while following the tutorial
in the tutorial excercise 'named slots', the 'paper.svg' has fill="none". The exercise is to build something that looks like a 'business card' on a table it seems, however you cannot see the card, so it looks more like words etched into wood! screenshot : https://prnt.sc/kpg6vljbZT-T
Fixes bad contrast in dark mode at, e.g., /numeric-inputs
* fix: smaller sidebar footer horizontal padding * fix: fine tune it
* Update README.md
docs: 04-updating-arrays-and-objects, add `let obj = { foo: { bar: 'old' } };` for more clarity
* Apply suggestions from code review
---------
Co-authored-by: Rich Harris <[email protected]>
* add aria-role:none to get rid of warning * Apply suggestions from code review --------- Co-authored-by: Rich Harris <[email protected]>
* fix: sidebar scrolls to top after navigate * fix: sidebar scrolls to top after navigate
Co-authored-by: Rich Harris <[email protected]>
Co-authored-by: Rich Harris <[email protected]>
Co-authored-by: Rich Harris <[email protected]>
* changed id from const to let * more const to let changes
…ideo (sveltejs#503) * Change "video" to "medium", as the word should cover both audio and video * Apply suggestions from code review * Apply suggestions from code review --------- Co-authored-by: Rich Harris <[email protected]>
* Clarify the items in the each needing ids/keys Try to clarify that it is updating the DOM/components after deleting the last item. For some reason, I read this as changing the array itself by removing the last item. I suspect my changes need to be slimmed down and edited. Yes, I am neuro-divergent. Why do you ask? 😃 * Apply suggestions from code review --------- Co-authored-by: Rich Harris <[email protected]>
|
@tomoam is attempting to deploy a commit to a Personal Account owned by @svelte-jp on Vercel. @svelte-jp first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.