Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source generator - Improved diagnostics #79

Merged
merged 38 commits into from
Oct 5, 2024
Merged

Source generator - Improved diagnostics #79

merged 38 commits into from
Oct 5, 2024

Conversation

sveinungf
Copy link
Owner

No description provided.

Copy link

codecov bot commented Oct 5, 2024

Codecov Report

Attention: Patch coverage is 82.62108% with 61 lines in your changes missing coverage. Please review.

Project coverage is 89.69%. Comparing base (6eb25fe) to head (fe1b130).
Report is 39 commits behind head on main.

Files with missing lines Patch % Lines
...tah.SourceGenerator/Helpers/DiagnosticsReporter.cs 67.79% 0 Missing and 19 partials ⚠️
...heetah.SourceGenerator/Helpers/PropertyAnalyzer.cs 87.96% 6 Missing and 7 partials ⚠️
...eadCheetah.SourceGenerator/WorksheetRowAnalyzer.cs 85.71% 9 Missing and 4 partials ⚠️
...tah.SourceGenerator/Extensions/SymbolExtensions.cs 76.00% 5 Missing and 7 partials ⚠️
SpreadCheetah.SourceGenerator/Diagnostics.cs 83.33% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
- Coverage   89.93%   89.69%   -0.25%     
==========================================
  Files         158      157       -1     
  Lines        5217     5309      +92     
  Branches      967      995      +28     
==========================================
+ Hits         4692     4762      +70     
- Misses        217      219       +2     
- Partials      308      328      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 5, 2024

Test Results

    11 files  ±0      11 suites  ±0   12m 12s ⏱️ + 3m 6s
 4 492 tests  - 6   4 492 ✅  - 6  0 💤 ±0  0 ❌ ±0 
17 557 runs  +6  17 557 ✅ +6  0 💤 ±0  0 ❌ ±0 

Results for commit fe1b130. ± Comparison against base commit 6eb25fe.

This pull request removes 46 and adds 40 tests. Note that renamed tests count towards both.
SpreadCheetah.SourceGenerator.SnapshotTest.Tests.WorksheetRowGeneratorCellValueTruncateTests ‑ WorksheetRowGenerator_Generate_ClassWithCellValueTruncate
SpreadCheetah.SourceGenerator.SnapshotTest.Tests.WorksheetRowGeneratorCellValueTruncateTests ‑ WorksheetRowGenerator_Generate_ClassWithCellValueTruncateOnInvalidType
SpreadCheetah.SourceGenerator.SnapshotTest.Tests.WorksheetRowGeneratorCellValueTruncateTests ‑ WorksheetRowGenerator_Generate_ClassWithCellValueTruncateWithInvalidLength
SpreadCheetah.SourceGenerator.SnapshotTest.Tests.WorksheetRowGeneratorCellValueTruncateTests ‑ WorksheetRowGenerator_Generate_ClassWithMultipleCellValueTruncate
SpreadCheetah.SourceGenerator.SnapshotTest.Tests.WorksheetRowGeneratorColumnHeaderTests ‑ WorksheetRowGenerator_Generate_ClassWithColumnHeaderForAllProperties
SpreadCheetah.SourceGenerator.SnapshotTest.Tests.WorksheetRowGeneratorColumnHeaderTests ‑ WorksheetRowGenerator_Generate_ClassWithInvalidPropertyReferenceColumnHeaders
SpreadCheetah.SourceGenerator.SnapshotTest.Tests.WorksheetRowGeneratorColumnHeaderTests ‑ WorksheetRowGenerator_Generate_ClassWithPropertyReferenceColumnHeaders
SpreadCheetah.SourceGenerator.SnapshotTest.Tests.WorksheetRowGeneratorColumnHeaderTests ‑ WorksheetRowGenerator_Generate_ClassWithSpecialCharacterColumnHeaders
SpreadCheetah.SourceGenerator.SnapshotTest.Tests.WorksheetRowGeneratorColumnOrderTests ‑ WorksheetRowGenerator_Generate_ClassWithColumnOrderForAllProperties
SpreadCheetah.SourceGenerator.SnapshotTest.Tests.WorksheetRowGeneratorColumnOrderTests ‑ WorksheetRowGenerator_Generate_ClassWithColumnOrderForSomeProperties
…
SpreadCheetah.SourceGenerator.SnapshotTest.Tests.CachingTests ‑ Caching_IncrementalSourceGeneratorCachingCorrectly
SpreadCheetah.SourceGenerator.SnapshotTest.Tests.CellValueTruncateTests ‑ CellValueTruncate_ClassWithCellValueTruncate
SpreadCheetah.SourceGenerator.SnapshotTest.Tests.CellValueTruncateTests ‑ CellValueTruncate_ClassWithCellValueTruncateOnInvalidType
SpreadCheetah.SourceGenerator.SnapshotTest.Tests.CellValueTruncateTests ‑ CellValueTruncate_ClassWithCellValueTruncateWithInvalidLength
SpreadCheetah.SourceGenerator.SnapshotTest.Tests.CellValueTruncateTests ‑ CellValueTruncate_ClassWithMultipleCellValueTruncate
SpreadCheetah.SourceGenerator.SnapshotTest.Tests.ColumnHeaderTests ‑ ColumnHeader_ClassWithColumnHeaderForAllProperties
SpreadCheetah.SourceGenerator.SnapshotTest.Tests.ColumnHeaderTests ‑ ColumnHeader_ClassWithInvalidPropertyReferenceColumnHeaders
SpreadCheetah.SourceGenerator.SnapshotTest.Tests.ColumnHeaderTests ‑ ColumnHeader_ClassWithPropertyReferenceColumnHeaders
SpreadCheetah.SourceGenerator.SnapshotTest.Tests.ColumnHeaderTests ‑ ColumnHeader_ClassWithSpecialCharacterColumnHeaders
SpreadCheetah.SourceGenerator.SnapshotTest.Tests.ColumnOrderTests ‑ ColumnOrder_ClassWithColumnOrderForAllProperties
…

♻️ This comment has been updated with latest results.

@sveinungf sveinungf merged commit 8850c25 into main Oct 5, 2024
2 of 4 checks passed
@sveinungf sveinungf deleted the dev/diagnostics branch October 12, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant