Package updates and test report

.github/workflows/dotnet.yml

@@ -11,24 +11,30 @@ on:
 
 jobs:
   build:
+    permissions:
+      checks: write
+      pull-requests: write
 
     runs-on: windows-latest
 
     steps:
-    - name: Configure Git to allow long paths
-      run: git config --system core.longpaths true
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
     - name: Setup .NET
-      uses: actions/setup-dotnet@v3
+      uses: actions/setup-dotnet@v4
       with:
         dotnet-version: 8.0.x
     - name: Restore dependencies
       run: dotnet restore
     - name: Build
       run: dotnet build --no-restore
     - name: Test
-      run: dotnet test --no-build --verbosity normal --collect:"XPlat Code Coverage"
+      run: dotnet test --no-build --verbosity normal --logger trx --collect:"XPlat Code Coverage"
     - name: Upload coverage reports to Codecov
       uses: codecov/codecov-action@v3
       env:
         CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
+    - name: Publish Test Results
+      uses: EnricoMi/publish-unit-test-result-action/windows@v2
+      if: always()
+      with:
+        files: ${{ github.workspace }}/**/*.trx

Directory.Packages.props

@@ -5,26 +5,26 @@
   </PropertyGroup>
   <ItemGroup>
     <GlobalPackageReference Include="ErrorProne.NET.CoreAnalyzers" Version="0.4.0-beta.1" />
-    <GlobalPackageReference Include="Meziantou.Analyzer" Version="2.0.163" />
+    <GlobalPackageReference Include="Meziantou.Analyzer" Version="2.0.169" />
     <GlobalPackageReference Include="Microsoft.CodeAnalysis.BannedApiAnalyzers" Version="3.3.4" />
     <GlobalPackageReference Include="Microsoft.VisualStudio.Threading.Analyzers" Version="17.11.20" />
     <GlobalPackageReference Include="PrimaryConstructorAnalyzer" Version="1.0.6" />
-    <GlobalPackageReference Include="Roslynator.Analyzers" Version="4.12.4" />
+    <GlobalPackageReference Include="Roslynator.Analyzers" Version="4.12.7" />
     <GlobalPackageReference Include="SonarAnalyzer.CSharp" Version="9.32.0.97167" />
   </ItemGroup>
   <ItemGroup>
     <PackageVersion Include="BenchmarkDotNet" Version="0.14.0" />
-    <PackageVersion Include="Bogus" Version="35.6.0" />
-    <PackageVersion Include="ClosedXML" Version="0.102.3" />
+    <PackageVersion Include="Bogus" Version="35.6.1" />
+    <PackageVersion Include="ClosedXML" Version="0.104.1" />
     <PackageVersion Include="coverlet.collector" Version="6.0.2" />
-    <PackageVersion Include="DocumentFormat.OpenXml" Version="2.20.0" />
+    <PackageVersion Include="DocumentFormat.OpenXml" Version="3.1.0" />
     <PackageVersion Include="EPPlusFree" Version="4.5.3.8" />
     <PackageVersion Include="ErrorProne.NET.Structs" Version="0.4.0-beta.1" />
     <PackageVersion Include="Microsoft.Bcl.AsyncInterfaces" Version="1.1.1" />
     <PackageVersion Include="Microsoft.Bcl.HashCode" Version="1.1.1" />
     <PackageVersion Include="Microsoft.CodeAnalysis.Analyzers" Version="3.3.4" />
     <PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.9.2" />
-    <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.11.0" />
+    <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.11.1" />
     <PackageVersion Include="Polyfill" Version="6.2.0" />
     <PackageVersion Include="PolySharp" Version="1.14.1" />
     <PackageVersion Include="PublicApiGenerator" Version="11.1.0" />
@@ -33,10 +33,10 @@
     <PackageVersion Include="System.Memory" Version="4.5.5" />
     <PackageVersion Include="System.Reflection.Metadata" Version="8.0.0" />
     <PackageVersion Include="TngTech.ArchUnitNET.xUnit" Version="0.11.0" />
-    <PackageVersion Include="Verify.SourceGenerators" Version="2.4.0" />
-    <PackageVersion Include="Verify.Xunit" Version="26.3.0" />
-    <PackageVersion Include="xunit" Version="2.9.0" />
-    <PackageVersion Include="xunit.assert" Version="2.9.0" />
+    <PackageVersion Include="Verify.SourceGenerators" Version="2.5.0" />
+    <PackageVersion Include="Verify.Xunit" Version="26.6.0" />
+    <PackageVersion Include="xunit" Version="2.9.2" />
+    <PackageVersion Include="xunit.assert" Version="2.9.2" />
     <PackageVersion Include="xunit.runner.visualstudio" Version="2.8.2" />
   </ItemGroup>
 </Project>

SpreadCheetah.Benchmark/SpreadCheetah.Benchmark.csproj

@@ -3,6 +3,7 @@
   <PropertyGroup>
     <OutputType>Exe</OutputType>
     <TargetFrameworks>net48;net6.0;net7.0;net8.0</TargetFrameworks>
+    <PlatformTarget>AnyCPU</PlatformTarget>
   </PropertyGroup>
 
   <ItemGroup>

SpreadCheetah.SourceGenerator.SnapshotTest/Snapshots/G.CellStyle_ClassWithEmptyCellStyle.verified.txt

@@ -1,14 +1,17 @@
 {
   Diagnostics: [
     {
-      Id: SPCH1006,
-      Title: Invalid attribute argument,
-      Severity: Error,
-      WarningLevel: 0,
       Location: : (6,5)-(6,18),
-      MessageFormat: '{0}' is an invalid argument for {1},
       Message: '' is an invalid argument for CellStyleAttribute,
-      Category: SpreadCheetah.SourceGenerator
+      Severity: Error,
+      Descriptor: {
+        Id: SPCH1006,
+        Title: Invalid attribute argument,
+        MessageFormat: '{0}' is an invalid argument for {1},
+        Category: SpreadCheetah.SourceGenerator,
+        DefaultSeverity: Error,
+        IsEnabledByDefault: true
+      }
     }
   ]
 }

SpreadCheetah.SourceGenerator.SnapshotTest/Snapshots/G.CellValueConverter_ClassPropertyWithConverterAndCellValueTruncate.verified.txt

@@ -1,14 +1,17 @@
 {
   Diagnostics: [
     {
-      Id: SPCH1008,
-      Title: Attribute combination not supported,
-      Severity: Error,
-      WarningLevel: 0,
       Location: : (7,19)-(7,27),
-      MessageFormat: Having both the {0} and the {1} attributes on a property is not supported,
       Message: Having both the CellValueConverter and the CellValueTruncate attributes on a property is not supported,
-      Category: SpreadCheetah.SourceGenerator
+      Severity: Error,
+      Descriptor: {
+        Id: SPCH1008,
+        Title: Attribute combination not supported,
+        MessageFormat: Having both the {0} and the {1} attributes on a property is not supported,
+        Category: SpreadCheetah.SourceGenerator,
+        DefaultSeverity: Error,
+        IsEnabledByDefault: true
+      }
     }
   ]
 }

SpreadCheetah.SourceGenerator.SnapshotTest/Snapshots/G.CellValueConverter_ClassWithConverterThatDoesNotInheritCellValueConverter.verified.txt

@@ -1,14 +1,17 @@
 {
   Diagnostics: [
     {
-      Id: SPCH1007,
-      Title: Invalid attribute type argument,
-      Severity: Error,
-      WarningLevel: 0,
       Location: : (5,5)-(5,54),
-      MessageFormat: Type '{0}' is an invalid argument for {1} because it does not inherit {2},
       Message: Type 'MyNamespace.DecimalValueConverter' is an invalid argument for CellValueConverterAttribute because it does not inherit CellValueConverter<decimal>,
-      Category: SpreadCheetah.SourceGenerator
+      Severity: Error,
+      Descriptor: {
+        Id: SPCH1007,
+        Title: Invalid attribute type argument,
+        MessageFormat: Type '{0}' is an invalid argument for {1} because it does not inherit {2},
+        Category: SpreadCheetah.SourceGenerator,
+        DefaultSeverity: Error,
+        IsEnabledByDefault: true
+      }
     }
   ]
 }

SpreadCheetah.SourceGenerator.SnapshotTest/Snapshots/G.CellValueConverter_ClassWithInvalidConverter.verified.txt

@@ -1,14 +1,17 @@
 {
   Diagnostics: [
     {
-      Id: SPCH1007,
-      Title: Invalid attribute type argument,
-      Severity: Error,
-      WarningLevel: 0,
       Location: : (5,5)-(5,54),
-      MessageFormat: Type '{0}' is an invalid argument for {1} because it does not inherit {2},
       Message: Type 'MyNamespace.DecimalValueConverter' is an invalid argument for CellValueConverterAttribute because it does not inherit CellValueConverter<string>,
-      Category: SpreadCheetah.SourceGenerator
+      Severity: Error,
+      Descriptor: {
+        Id: SPCH1007,
+        Title: Invalid attribute type argument,
+        MessageFormat: Type '{0}' is an invalid argument for {1} because it does not inherit {2},
+        Category: SpreadCheetah.SourceGenerator,
+        DefaultSeverity: Error,
+        IsEnabledByDefault: true
+      }
     }
   ]
 }

SpreadCheetah.SourceGenerator.SnapshotTest/Snapshots/G.CellValueConverter_ClassWithInvalidConverterOnComplexProperty.verified.txt

@@ -1,24 +1,31 @@
 {
   Diagnostics: [
     {
-      Id: SPCH1007,
-      Title: Invalid attribute type argument,
-      Severity: Error,
-      WarningLevel: 0,
       Location: : (5,5)-(5,48),
-      MessageFormat: Type '{0}' is an invalid argument for {1} because it does not inherit {2},
       Message: Type 'MyNamespace.StringConverter' is an invalid argument for CellValueConverterAttribute because it does not inherit CellValueConverter<object>,
-      Category: SpreadCheetah.SourceGenerator
+      Severity: Error,
+      Descriptor: {
+        Id: SPCH1007,
+        Title: Invalid attribute type argument,
+        MessageFormat: Type '{0}' is an invalid argument for {1} because it does not inherit {2},
+        Category: SpreadCheetah.SourceGenerator,
+        DefaultSeverity: Error,
+        IsEnabledByDefault: true
+      }
     },
     {
-      Id: SPCH1002,
-      Title: Unsupported type for cell value,
-      Severity: Warning,
-      WarningLevel: 1,
       Location: : (16,1)-(16,65),
-      MessageFormat: The type '{0}' has a property of type '{1}' which is not supported as a cell value. The property will be ignored when creating the row.,
       Message: The type 'ClassWithInvalidConverterOnComplexProperty' has a property of type 'Object' which is not supported as a cell value. The property will be ignored when creating the row.,
-      Category: SpreadCheetah.SourceGenerator
+      Severity: Warning,
+      WarningLevel: 1,
+      Descriptor: {
+        Id: SPCH1002,
+        Title: Unsupported type for cell value,
+        MessageFormat: The type '{0}' has a property of type '{1}' which is not supported as a cell value. The property will be ignored when creating the row.,
+        Category: SpreadCheetah.SourceGenerator,
+        DefaultSeverity: Warning,
+        IsEnabledByDefault: true
+      }
     }
   ]
 }

SpreadCheetah.SourceGenerator.SnapshotTest/Snapshots/G.CellValueConverter_ClassWithoutParameterlessConstructor.verified.txt

@@ -1,14 +1,17 @@
 {
   Diagnostics: [
     {
-      Id: SPCH1009,
-      Title: Type must have a public parameterless constructor,
-      Severity: Error,
-      WarningLevel: 0,
       Location: : (5,5)-(5,52),
-      MessageFormat: Type '{0}' must have a public parameterless constructor,
       Message: Type 'MyNamespace.FixedValueConverter' must have a public parameterless constructor,
-      Category: SpreadCheetah.SourceGenerator
+      Severity: Error,
+      Descriptor: {
+        Id: SPCH1009,
+        Title: Type must have a public parameterless constructor,
+        MessageFormat: Type '{0}' must have a public parameterless constructor,
+        Category: SpreadCheetah.SourceGenerator,
+        DefaultSeverity: Error,
+        IsEnabledByDefault: true
+      }
     }
   ]
 }

SpreadCheetah.SourceGenerator.SnapshotTest/Snapshots/G.WorksheetRowGenerator_Generate_ClassWithCellValueTruncateOnInvalidType.verified.txt

@@ -1,14 +1,17 @@
 {
   Diagnostics: [
     {
-      Id: SPCH1005,
-      Title: Unsupported type for attribute,
-      Severity: Error,
-      WarningLevel: 0,
       Location: : (6,5)-(6,26),
-      MessageFormat: {0} is not supported on properties of type '{1}',
       Message: CellValueTruncateAttribute is not supported on properties of type 'int',
-      Category: SpreadCheetah.SourceGenerator
+      Severity: Error,
+      Descriptor: {
+        Id: SPCH1005,
+        Title: Unsupported type for attribute,
+        MessageFormat: {0} is not supported on properties of type '{1}',
+        Category: SpreadCheetah.SourceGenerator,
+        DefaultSeverity: Error,
+        IsEnabledByDefault: true
+      }
     }
   ]
 }

SpreadCheetah.SourceGenerator.SnapshotTest/Snapshots/G.WorksheetRowGenerator_Generate_ClassWithCellValueTruncateWithInvalidLength.verified.txt

@@ -1,14 +1,17 @@
 {
   Diagnostics: [
     {
-      Id: SPCH1006,
-      Title: Invalid attribute argument,
-      Severity: Error,
-      WarningLevel: 0,
       Location: : (6,5)-(6,25),
-      MessageFormat: '{0}' is an invalid argument for {1},
       Message: '0' is an invalid argument for CellValueTruncateAttribute,
-      Category: SpreadCheetah.SourceGenerator
+      Severity: Error,
+      Descriptor: {
+        Id: SPCH1006,
+        Title: Invalid attribute argument,
+        MessageFormat: '{0}' is an invalid argument for {1},
+        Category: SpreadCheetah.SourceGenerator,
+        DefaultSeverity: Error,
+        IsEnabledByDefault: true
+      }
     }
   ]
 }

SpreadCheetah.SourceGenerator.SnapshotTest/Snapshots/G.WorksheetRowGenerator_Generate_ClassWithColumnWidthWithInvalidWidth.verified.txt

@@ -1,14 +1,17 @@
 {
   Diagnostics: [
     {
-      Id: SPCH1006,
-      Title: Invalid attribute argument,
-      Severity: Error,
-      WarningLevel: 0,
       Location: : (6,5)-(6,21),
-      MessageFormat: '{0}' is an invalid argument for {1},
       Message: '300' is an invalid argument for ColumnWidthAttribute,
-      Category: SpreadCheetah.SourceGenerator
+      Severity: Error,
+      Descriptor: {
+        Id: SPCH1006,
+        Title: Invalid attribute argument,
+        MessageFormat: '{0}' is an invalid argument for {1},
+        Category: SpreadCheetah.SourceGenerator,
+        DefaultSeverity: Error,
+        IsEnabledByDefault: true
+      }
     }
   ]
 }

SpreadCheetah.SourceGenerator.SnapshotTest/Snapshots/G.WorksheetRowGenerator_Generate_ClassWithDuplicateColumnOrdering.verified.txt

@@ -1,14 +1,17 @@
 {
   Diagnostics: [
     {
-      Id: SPCH1003,
-      Title: Duplicate column ordering,
-      Severity: Error,
-      WarningLevel: 0,
       Location: : (8,5)-(8,19),
-      MessageFormat: The type '{0}' has two or more properties with the same column order,
       Message: The type 'ClassWithDuplicateColumnOrdering' has two or more properties with the same column order,
-      Category: SpreadCheetah.SourceGenerator
+      Severity: Error,
+      Descriptor: {
+        Id: SPCH1003,
+        Title: Duplicate column ordering,
+        MessageFormat: The type '{0}' has two or more properties with the same column order,
+        Category: SpreadCheetah.SourceGenerator,
+        DefaultSeverity: Error,
+        IsEnabledByDefault: true
+      }
     }
   ]
 }

SpreadCheetah.SourceGenerator.SnapshotTest/Snapshots/G.WorksheetRowGenerator_Generate_ClassWithDuplicateColumnOrderingAcrossInheritance.verified.txt

@@ -1,14 +1,17 @@
 {
   Diagnostics: [
     {
-      Id: SPCH1003,
-      Title: Duplicate column ordering,
-      Severity: Error,
-      WarningLevel: 0,
       Location: : (7,5)-(7,19),
-      MessageFormat: The type '{0}' has two or more properties with the same column order,
       Message: The type 'ClassWithDuplicateColumnOrdering' has two or more properties with the same column order,
-      Category: SpreadCheetah.SourceGenerator
+      Severity: Error,
+      Descriptor: {
+        Id: SPCH1003,
+        Title: Duplicate column ordering,
+        MessageFormat: The type '{0}' has two or more properties with the same column order,
+        Category: SpreadCheetah.SourceGenerator,
+        DefaultSeverity: Error,
+        IsEnabledByDefault: true
+      }
     }
   ]
 }