Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source generator - CellValueConverter #72

Merged
merged 56 commits into from
Sep 7, 2024
Merged

Source generator - CellValueConverter #72

merged 56 commits into from
Sep 7, 2024

Conversation

sveinungf
Copy link
Owner

No description provided.

kobyakov added 30 commits August 22, 2024 21:26
add cell value mapper attribute, ICellValueMapper.cs for source gener…
19227d1 
…ator
use constant instead of string
48d7837
remove styleName from ICellValueMapper.cs arguments
6ec6265
WIP: template version how to use user mapper
7900947
don't generate _cellValueMappers if no mappers exists for a class
87ef65c
rename ICellValueMapper.cs to CellValueConverter.cs
40cb247
add constructor with DataCell in StyledCell.cs
a0901e8
emit error if property has CellValueConverterAttribute and TruncateVa…
2319350 
…lueAttribute
use dictionary instead of an array. allow only one instance per cell …
a98624a 
…value converter type
add test when cell value converter exists
4c4f939
add test when the same cell value converter exists
f4e9293
add diagnostic
f6fc9f5
emit error if a type doesn't have a public parameterless constructor
5e1f28a
add test when class doesn't have a public parameterless constructor f…
beb216d 
…or CellValueConverter
generate code for CellValueConverters only once
85719a4
Merge branch 'refs/heads/main' into dev/src-gen-cell_value_mapper
d8b12b2
remove additional constructor from StyledCell.cs
b997580
emit error if the CellValueConverter generic different from the prope…
deb1415 
…rty type
use ToDisplayString() to compare types and avoid bug when comparing n…
6ec84eb 
…ullable types
Merge branch 'refs/heads/dev/src-gen-cellstyle' into dev/src-gen-cell…
a13bf80 
…_value_mapper

# Conflicts:
#	SpreadCheetah.SourceGenerator/WorksheetRowGenerator.cs
update tests
cc5080a
Merge branch 'refs/heads/dev/src-gen-cellstyle' into dev/src-gen-cell…
1334c03 
…_value_mapper
use styled cells with cell value converter
75f01de
Merge branch 'refs/heads/main' into dev/src-gen-cell_value_mapper
2586c5d
remove class usage from attribute and update tests
8ba0f95
fix tests
8fb20ba
add test for a case when CellValueConverter with CellStyle
2280f40
add missing test
e7c2b62
add primary constructor to CellValueConverterAttribute.cs fix checkin…
95b6d8a 
…g for the base type op CellValueConverter, update test
update tests
91cf9a2
kobyakov and others added 25 commits September 3, 2024 18:40
remove the dictionary with cell value converters
25561d8
fix an error message
4459f8d
update tests
e3c7d3c
fix tests
65d733c
fix tests and delete classes for CellValueConverter test
9dd9d02
update public api tests
7615226
@sveinungf
Merge pull request #69 from Ashymonth/dev/src-gen-cell_value_mapper
0c29c21 
Dev/src gen cell value mapper
@sveinungf
Update XML comments and suppressions for CellValueConverter classes
0bd883b
@sveinungf
Refactor use of diagnostics
c5e234e
@sveinungf
Made diagnostic SPCH1007 more general, so it can be used on more attr…
83b7d32 
…ibutes in the future
@sveinungf
Made diagnostic SPCH1008 more general, so it can be used for more att…
c93e2bc 
…ributes in the future
@sveinungf
Update test snapshots
7da7656
@sveinungf
Use "onlyDiagnostics: true" for snapshot tests where we only need the…
4b21ddd 
… diagnostics
@sveinungf
Made diagnostic SPCH1009 more general, so it can be used for more att…
970e15a 
…ributes in the future
@sveinungf
Remove redundant diagnostic
55e1484
@sveinungf
Simplify ConstructCell in source generator
f2eb2fa
@sveinungf
Update test snapshots
9c33ce9
@sveinungf
Simplify snapshot tests for CellValueConverter
9e47918
@sveinungf
Fix issue with reusing CellValueConverters not working as intended
5b4cee0
@sveinungf
Add CellValueConverters to test for class with all src gen attributes
3ec9492
@sveinungf
Add CellValueConverters to C# 8 test for class with all src gen attri…
2c4a9fc 
…butes
@sveinungf
Regular tests for CellValueConverter
fe9ea56
@sveinungf
Test for two classes using the same CellValueConverter
690f362
@sveinungf
Test for property with CellValueConverter and CellStyle
57097f4
@sveinungf
Update snapshots for public API
c630ed1
@codecov Codecov
Copy link

codecov bot commented Sep 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.90164% with 5 lines in your changes missing coverage. Please review.

Project coverage is 89.89%. Comparing base (4e8ef39) to head (115ce1b).
Report is 57 commits behind head on main.

Files with missing lines Patch % Lines
...rceGenerator/Extensions/AttributeDataExtensions.cs 92.30% 1 Missing and 1 partial ⚠️
SpreadCheetah.SourceGenerator/Diagnostics.cs 97.50% 0 Missing and 1 partial ⚠️
...adCheetah.SourceGenerator/WorksheetRowGenerator.cs 98.03% 0 Missing and 1 partial ⚠️
...ah/SourceGeneration/CellValueConverterAttribute.cs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
+ Coverage   89.78%   89.89%   +0.11%     
==========================================
  Files         156      158       +2     
  Lines        5131     5217      +86     
  Branches      955      967      +12     
==========================================
+ Hits         4607     4690      +83     
- Misses        215      217       +2     
- Partials      309      310       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sveinungf sveinungf merged commit 0447c23 into main Sep 7, 2024
3 checks passed
@sveinungf sveinungf deleted the dev/src-gen-cellvalueconverter branch October 12, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sveinungf