Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mode-watcher-full.svelte #108

Merged
merged 5 commits into from
Jan 24, 2025
Merged

Conversation

jdgamble555
Copy link
Contributor

Ignore hydration_html_changed error

Ignore hydration_html_changed error
Copy link

changeset-bot bot commented Jan 21, 2025

⚠️ No Changeset found

Latest commit: 129480e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 21, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
mode-watcher ✅ Ready (View Log) Visit Preview 84236af

@huntabyte
Copy link
Member

Hey @jdgamble555, does this rid that log message?? If so, can it be moved above the eslint ignore and still work so CI can pass?

@jdgamble555
Copy link
Contributor Author

@huntabyte - It seems to work in my test REPO so I would say yes.

https://github.com/jdgamble555/svelte-hydration-error/blob/master/src/routes/%2Blayout.svelte

J

put svelte ignore above eslint comment
@jdgamble555
Copy link
Contributor Author

It looks the error that is not passing is expected?

J

move svelte-ignore and eslint comment to same line
disable no-unused-svelte-ignore for the file
@jdgamble555
Copy link
Contributor Author

@huntabyte - And all checks pass!

I think the error was being caused because eslint-plugin-svelte does not understand that ignoring hydration_html_changed is an actual real error.

J

Copy link
Member

@huntabyte huntabyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a shot!

@huntabyte huntabyte merged commit fd14254 into svecosystem:main Jan 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants