chore: update gems #381
chore: update gems #381
Conversation
|
@XhmikosR Does this look right to you? |
RichardLitt
force-pushed
the
feat/update-gems
branch
from
8542620 to
66ff574
Compare
|
I'm on mobile but CI seems to be broken.
We might need to update CI actions before this
…On Wed, Jul 17, 2024, 20:10 Richard Littauer ***@***.***> wrote:
@XhmikosR <https://github.com/XhmikosR> Does this look right to you?
—
Reply to this email directly, view it on GitHub
<#381 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACVLNLPXDYXRZOOTXZWT7LZM2QQHAVCNFSM6AAAAABLBBOGUSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZTG44TKMBYHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I think it is - still using old Node and older Ruby versions, and I'm not sure why. I would appreciate help! |
|
I'll have a look tomorrow!
…On Wed, Jul 17, 2024, 20:47 Richard Littauer ***@***.***> wrote:
I think it is - still using old Node and older Ruby versions, and I'm not
sure why. I would appreciate help!
—
Reply to this email directly, view it on GitHub
<#381 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACVLNITNKFX5ZCUDWGJMDLZM2UZ7AVCNFSM6AAAAABLBBOGUSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZTHA3DOMRTGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Thank you! No rush at all. I appreciate your work. |
|
@RichardLitt everything should be OK now. That .ruby-version file takes precedence over the Netlify dashboard environment variables so I had to update that too. I only kept html-proofer back and eslint because they need more work and I don't have time. Generally, if CI is not green, the patch shouldn't land :) |
|
Amazing! Thank you so much. :) This is great. |
|
I wish I could look over your shoulder and see how you did this. There're some steps in here I don't fully understand. But again - grateful. |
|
I kept the patches separate for this reason :) First CI, then gems, then npm deps and adapted the code if needed so that CI is still green. |
Just updating them all. Not sure why this didn't change the Gemfile, but whatever?